Add OpenAPI tool #246
Merged
Add OpenAPI tool #246
+348
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tomas2D
requested changes
Dec 12, 2024
src/tools/openapi.ts
Outdated
| description?: string; | ||
| openApiSchema?: any; | ||
| apiKey?: string; | ||
| http_proxy_url?: string; |
src/tools/openapi.ts
Outdated
| http_proxy_url?: string; | ||
| } | ||
|
|
||
| type ToolRunOptions = BaseToolRunOptions; |
src/tools/openapi.ts
Outdated
| } | ||
| } | ||
|
|
||
| export class OpenAPI extends Tool<StringToolOutput, OpenAPIOptions, ToolRunOptions> { |
There was a problem hiding this comment.
ToolRunOptions can be removed.
There was a problem hiding this comment.
The response class does not match the reality.
It should be OpenAPIToolOutput, not StringToolOutput.
src/tools/openapi.ts
Outdated
Comment on lines
112
to
113
| //ToolInput<this>, | ||
| any, |
There was a problem hiding this comment.
Replace with Record<string, any>
src/tools/openapi.ts
Outdated
| public readonly emitter: ToolEmitter< | ||
| //ToolInput<this>, | ||
| any, | ||
| StringToolOutput, |
There was a problem hiding this comment.
Should be OpenAPIToolOutput
src/tools/openapi.ts
Outdated
| // eslint-disable-next-line @typescript-eslint/consistent-indexed-object-style | ||
| const headers: { [key: string]: string } = { Accept: "application/json" }; | ||
| if (this.apiKey) { | ||
| headers["Authorization"] = `Bearer this.apiKey`; |
There was a problem hiding this comment.
This does not work.
You probably wanted to do Bearer ${this.apiKey}.
src/tools/openapi.ts
Outdated
| headers: headers, | ||
| signal: AbortSignal.any([AbortSignal.timeout(30_000), run.signal]), | ||
| }); | ||
| return new StringToolOutput(await response.text()); |
src/tools/openapi.ts
Outdated
| body: !isEmpty(input.body) ? input.body : undefined, | ||
| method: input.method.toLowerCase(), | ||
| headers: headers, | ||
| signal: AbortSignal.any([AbortSignal.timeout(30_000), run.signal]), |
There was a problem hiding this comment.
Remove the AbortSignal.timeout() because a user can specify it via run parameters.
Tomas2D
reviewed
Dec 12, 2024
akihikokuroda
force-pushed
the
apitool
branch
from
4118170 to
599387d
Compare
Tomas2D
requested changes
Dec 13, 2024
src/tools/openapi.ts
Outdated
| } | ||
|
|
||
| protected async _run( | ||
| input: any, |
There was a problem hiding this comment.
What is the error message?
akihikokuroda
force-pushed
the
apitool
branch
4 times, most recently
from
1e85cb1 to
f718e60
Compare
Tomas2D
reviewed
Dec 19, 2024
Signed-off-by: Akihiko Kuroda <akihikokuroda2020@gmail.com>
akihikokuroda
force-pushed
the
apitool
branch
from
f718e60 to
d574e0e
Compare
Tomas2D
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) does this pull-request address?
Closes: #105
Description
Checklist
yarn lintoryarn lint:fixyarn formatoryarn format:fixyarn test:unityarn test:e2e