Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(observe): implement opentelemetry #113

Merged
merged 3 commits into from
Dec 11, 2024

Conversation

GALLLASMILAN
Copy link
Contributor

@GALLLASMILAN GALLLASMILAN commented Dec 6, 2024

The newly "Observe" Otlp backend implementation

  • remove the old connector package
  • update observe API schema and proxy routes
  • save the framework traceId => only one attribute via that I can load the trace from Observe
  • Some changes are only because of prettier (eslintrc.cjs, .github/workflows/main.yml, src/ui/jwks.json, tsconfig.json)

It must be merged with the related PR from Observe and UI

Related PR

@GALLLASMILAN GALLLASMILAN requested a review from a team as a code owner December 6, 2024 12:31
@GALLLASMILAN GALLLASMILAN marked this pull request as draft December 6, 2024 12:36
@GALLLASMILAN GALLLASMILAN force-pushed the implement-observe-telemetry branch from 2567d43 to b2fde46 Compare December 6, 2024 12:41
@GALLLASMILAN GALLLASMILAN marked this pull request as ready for review December 6, 2024 12:44
Copy link
Contributor

@pilartomas pilartomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert changes in all the config files with no actual edits.

@GALLLASMILAN
Copy link
Contributor Author

GALLLASMILAN commented Dec 6, 2024

Please revert changes in all the config files with no actual edits.

Why? We should change the prettier, otherwise, the current formating is valid.
@pilartomas

@pilartomas
Copy link
Contributor

You're right, I had some rogue formatter for all "config" files set up in my VSCode which overrode prettier and that confused me. 👍

export type SpanReadQuery = FromSchema<typeof spanReadQuerySchema>;
export type SpanReadParamsSchema = FromSchema<typeof spanReadParamsSchema>;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo -> SpanReadParams

GALLLASMILAN and others added 3 commits December 11, 2024 12:25
Signed-off-by: GALLLASMILAN <gallas.milan@gmail.com>
Signed-off-by: GALLLASMILAN <gallas.milan@gmail.com>
Signed-off-by: Milan Gallas <Milan.Gallas@ibm.com>
@GALLLASMILAN GALLLASMILAN force-pushed the implement-observe-telemetry branch from 51dcf6d to 877e6ac Compare December 11, 2024 11:26
@matoushavlena matoushavlena merged commit f67e300 into main Dec 11, 2024
7 checks passed
@matoushavlena matoushavlena deleted the implement-observe-telemetry branch December 11, 2024 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants