-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(observe): implement opentelemetry #113
Conversation
2567d43
to
b2fde46
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please revert changes in all the config files with no actual edits.
Why? We should change the prettier, otherwise, the current formating is valid. |
You're right, I had some rogue formatter for all "config" files set up in my VSCode which overrode prettier and that confused me. 👍 |
834b880
to
77b8095
Compare
src/observe/dtos/span-read.ts
Outdated
export type SpanReadQuery = FromSchema<typeof spanReadQuerySchema>; | ||
export type SpanReadParamsSchema = FromSchema<typeof spanReadParamsSchema>; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo -> SpanReadParams
Signed-off-by: GALLLASMILAN <gallas.milan@gmail.com>
Signed-off-by: GALLLASMILAN <gallas.milan@gmail.com>
51dcf6d
to
877e6ac
Compare
The newly "Observe" Otlp backend implementation
traceId
=> only one attribute via that I can load the trace from Observeeslintrc.cjs
,.github/workflows/main.yml
,src/ui/jwks.json
,tsconfig.json
)Related PR