feat(trace): add retry after header #19
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #16
Changes
I added the
Retry-After
Definition
The HTTP Retry-After response header indicates how long the user agent should wait before making a follow-up request. There are three main cases this header is used:
for /v1/traces/{id} route
A 404 Not Found status code signifies that the resource does not exist on the server. Since the issue is not temporary, retrying the request later usually won’t make sense. For clients, this may cause confusion, as Retry-After suggests that the resource might become available after some time, which is contradictory to the meaning of 404.
! Because in the case of
v1/traces/{id}
the resource is temporarily unavailable. !