Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add namespace information to duplicate warnings #1091

Merged
merged 1 commit into from
Dec 26, 2024

Conversation

janpaepke
Copy link
Contributor

@janpaepke janpaepke commented Nov 28, 2024

Why am I submitting this PR

The warning message for duplicate keys is of limited usefulness, if it concerns a key that exists in multiple namespaces.
For example: the title key exists in 10 namespaces. When I get a warning that it's duplicate, I likely have accidentally used the wrong namespace somewhere, but I have no way of identifying where.

This PR Fixes this by adding the namespace to the log output.

Does it fix an existing ticket?

No #000

Checklist

  • only relevant code is changed (make a diff before you submit the PR)
  • tests are included and pass: yarn test (see details here) (no tests relevant)
  • documentation is changed or added

@janpaepke janpaepke marked this pull request as draft November 28, 2024 15:19
@janpaepke janpaepke changed the title use keyWithNamespace instead of key in warnings Add namespace information to duplicate warnings Nov 28, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 37.50000% with 5 lines in your changes missing coverage. Please review.

Project coverage is 95.16%. Comparing base (398b9ce) to head (3252e5e).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/transform.js 37.50% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1091      +/-   ##
==========================================
- Coverage   95.35%   95.16%   -0.20%     
==========================================
  Files          10       10              
  Lines        1918     1924       +6     
==========================================
+ Hits         1829     1831       +2     
- Misses         89       93       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@janpaepke janpaepke marked this pull request as ready for review November 29, 2024 08:32
@karellm karellm merged commit 4f12240 into i18next:master Dec 26, 2024
8 checks passed
@karellm
Copy link
Member

karellm commented Dec 26, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants