Upgrade vinyl-fs from 3.0.2 to 4.0.0 #930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
New dependencies detected. Learn more about Socket for GitHub ↗︎
|
|
Turned out glob-stream, used by vinyl-fs, only scans from the current directory and upwards, thus not finding temporary files created by Broccoli and in turn not creating translation files. I don't have experience with Broccoli though, so I'm a bit unsure if this change will have any implications on projects using i18next-parser with Broccoli. Added a note though to the readme file that hopefully provides enough information for Broccoli users. |
|
Thanks! This is deployed as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why am I submitting this PR
There is a high vulnerability attached to vinyl-fs' dependency tree, blocking me from being able to use this package in my own project. The automatic dependabot PR can't merge, due to changes in glob-handling, which I'm also handling in this PR.
Does it fix an existing ticket?
Yes #684
Checklist
yarn test(see details here)