Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Global JSX namespace is deprecated #1822

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

mrginglymus
Copy link
Contributor

The JSX Global namespace has been deprecated for a while, and removed in React 19: https://react.dev/blog/2024/04/25/react-19-upgrade-guide#the-jsx-namespace-in-typescript

@coveralls
Copy link

Coverage Status

coverage: 96.782%. remained the same
when pulling b92d7ab on mrginglymus:r19-type-compat
into 69a342c on i18next:master.

@adrai
Copy link
Member

adrai commented Dec 11, 2024

@marcalexiei ok for you?

@danielrentz
Copy link

fixes #1823

@adrai
Copy link
Member

adrai commented Dec 12, 2024

major, minor or patch version bump for TS users?

@danielrentz
Copy link

It will work with react v18 and v19... minor?

@adrai adrai merged commit eb372c4 into i18next:master Dec 12, 2024
9 checks passed
@adrai
Copy link
Member

adrai commented Dec 12, 2024

included in v15.2.0

@marcalexiei marcalexiei removed their request for review December 12, 2024 14:28
alexandresoro pushed a commit to alexandresoro/ouca that referenced this pull request Dec 22, 2024
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [react-i18next](https://github.com/i18next/react-i18next) | dependencies | minor | [`15.1.4` -> `15.2.0`](https://renovatebot.com/diffs/npm/react-i18next/15.1.4/15.2.0) |

---

### Release Notes

<details>
<summary>i18next/react-i18next (react-i18next)</summary>

### [`v15.2.0`](https://github.com/i18next/react-i18next/blob/HEAD/CHANGELOG.md#1520)

[Compare Source](i18next/react-i18next@v15.1.4...v15.2.0)

This version may be breaking if you still use React < v18 with TypeScript.
For JS users this version is equal to v15.1.4

-   fix: Global JSX namespace is deprecated [1823](i18next/react-i18next#1823) with [1822](i18next/react-i18next#1822)

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS44MC4wIiwidXBkYXRlZEluVmVyIjoiMzkuODAuMCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiZGVwZW5kZW5jaWVzIl19-->

Reviewed-on: https://git.tristess.app/alexandresoro/ouca/pulls/404
Reviewed-by: Alexandre Soro <code@soro.dev>
Co-authored-by: renovate <renovate@git.tristess.app>
Co-committed-by: renovate <renovate@git.tristess.app>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants