Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Order in alphabet sidebar #20

Open
marxsk opened this issue Jul 14, 2016 · 4 comments
Open

Order in alphabet sidebar #20

marxsk opened this issue Jul 14, 2016 · 4 comments

Comments

@marxsk
Copy link

marxsk commented Jul 14, 2016

Hi,

thanks for a great component. I have found two minor issues and if they are bugs, I can try to fix them but it is possible that I have just overlooked something.

Let's assume that we will just copy an example from main page. When we switch lines in state.data, we can get situation where sidebar is not in alphabet order. For hash that were created outside of project, it is hard to put items in an alphabet order (and order of keys in hash is not defined in ECMAscript). Should these keys be ordered?

Some languages (e.g. Czech) uses letters in alphabet that consist of multiple characters (e.g Ch). Currently, this is badly displayed on two lines at sidebar, will you accept a PR that will support multi-character letters? For usage with previous automatic ordering, it is possible to use localeCompare() that handles this without any issues.

Thanks

@sunnylqm
Copy link
Collaborator

Feel free to PR. And since I don't have much time to review, I am considering to transfer this repo. Are you interested? @marxsk

@sibelius
Copy link
Collaborator

sibelius commented Oct 6, 2016

@sunnylqm I'm willing to help improve this package, could u add me as a contributor?

@sunnylqm
Copy link
Collaborator

sunnylqm commented Oct 7, 2016

@sibelius welcome

@jacob-israel-turner
Copy link

I came here to ask about alphabetic order as well. Either there should be a sort function passed to the component, it should sort alphabetically by default, or it should be passed an array instead of an object. While some libraries do, it's kind of bad practice to rely on Object property ordering in JavaScript - it can be inconsistent between runtimes, since its order is not specified in the spec.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants