Add compareFunction to change order of sections #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sunnylqm looks good to me |
|
@sibelius I'd like to transfer this repo (both github and npm). Are you interested? |
|
@sunnylqm I think it is better to transfer it to @react-native-community cc @satya164 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This PR fixes the issue #20 at least the sort part of it. I was not able to find out the width of the rendered section title before rendering, so if anyone wants to use multiple characters on side, it is required to change width in the styles manually.
PR adds property 'compareFunction(a,b)' as used in sort(). Afterwards, it is possible to have sorted sections without requirement them in a specific order.