Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Will allow side alphabet list to work properly on android when the co… #36

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
91 changes: 45 additions & 46 deletions components/CellWrapper.js
Original file line number Diff line number Diff line change
@@ -1,46 +1,45 @@
'use strict';

import React, {
Component,
PropTypes
} from 'react';
import ReactNative, {
View
} from 'react-native';

export default class CellWrapper extends Component {
componentDidMount() {
this.props.updateTag && this.props.updateTag(ReactNative.findNodeHandle(this.refs.view), this.props.sectionId);
}

render() {
const Cell = this.props.component;
return (
<View ref='view'>
<Cell {...this.props} />
</View>
);
}
}

CellWrapper.propTypes = {

/**
* The id of the section
*/
sectionId: PropTypes.oneOfType([
PropTypes.number,
PropTypes.string
]),

/**
* A component to render for each cell
*/
component: PropTypes.func.isRequired,

/**
* A function used to propagate the root nodes handle back to the parent
*/
updateTag: PropTypes.func

};
'use strict';

import React, { Component } from 'react';
import PropTypes from 'prop-types';
import ReactNative, {
View
} from 'react-native';

export default class CellWrapper extends Component {

componentDidMount() {
this.props.updateTag && this.props.updateTag(ReactNative.findNodeHandle(this.refs.view), this.props.sectionId);
}

render() {
var Cell = this.props.component;
return (
<View ref='view'>
<Cell {...this.props} />
</View>
);
}
}

CellWrapper.propTypes = {

/**
* The id of the section
*/
sectionId: PropTypes.oneOfType([
PropTypes.number,
PropTypes.string
]),

/**
* A component to render for each cell
*/
component: PropTypes.func.isRequired,

/**
* A function used to propagate the root nodes handle back to the parent
*/
updateTag: PropTypes.func

};
137 changes: 68 additions & 69 deletions components/SectionHeader.js
Original file line number Diff line number Diff line change
@@ -1,69 +1,68 @@
'use strict';

import React, {
Component,
PropTypes
} from 'react';
import ReactNative, {
StyleSheet,
View,
Text,
NativeModules
} from 'react-native';

const { UIManager } = NativeModules;

export default class SectionHeader extends Component {

componentDidMount() {
this.props.updateTag && this.props.updateTag(ReactNative.findNodeHandle(this.refs.view), this.props.sectionId);
}

render() {
const SectionComponent = this.props.component;
const content = SectionComponent ?
<SectionComponent {...this.props} /> :
<Text>{this.props.title}</Text>;

return (
<View ref="view">
{content}
</View>
);
}
}

const styles = StyleSheet.create({
container: {
backgroundColor:'#f8f8f8',
borderTopWidth: 1,
borderTopColor: '#ececec'
},
text: {
fontWeight: '700',
paddingTop:2,
paddingBottom:2,
paddingLeft: 2
}
});

SectionHeader.propTypes = {

/**
* The id of the section
*/
sectionId: PropTypes.oneOfType([
PropTypes.number,
PropTypes.string
]),

/**
* A component to render for each section item
*/
component: PropTypes.func,

/**
* A function used to propagate the root nodes handle back to the parent
*/
updateTag: PropTypes.func
};
'use strict';

import React, { Component } from 'react';
import PropTypes from 'prop-types';
import ReactNative, {
StyleSheet,
View,
Text,
NativeModules
} from 'react-native';

const UIManager = NativeModules;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete - UIManager not used in this file


export default class SectionHeader extends Component {

componentDidMount() {
this.props.updateTag && this.props.updateTag(ReactNative.findNodeHandle(this.refs.view), this.props.sectionId);
}

render() {
var SectionComponent = this.props.component;
var content = SectionComponent ?
<SectionComponent {...this.props} /> :
<Text style={styles.text}>{this.props.title}</Text>;

return (
<View ref="view" style={styles.container}>
{content}
</View>
);
}
}

var styles = StyleSheet.create({
container: {
backgroundColor:'#f8f8f8',
borderTopWidth: 1,
borderTopColor: '#ececec'
},
text: {
fontWeight: '700',
paddingTop:2,
paddingBottom:2,
paddingLeft: 2
}
});

SectionHeader.propTypes = {

/**
* The id of the section
*/
sectionId: PropTypes.oneOfType([
PropTypes.number,
PropTypes.string
]),

/**
* A component to render for each section item
*/
component: PropTypes.func,

/**
* A function used to propagate the root nodes handle back to the parent
*/
updateTag: PropTypes.func

};
Loading