Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Config editor #281

Merged
merged 3 commits into from
Nov 7, 2024
Merged

Config editor #281

merged 3 commits into from
Nov 7, 2024

Conversation

chStaiger
Copy link
Collaborator

  • Check if save as filename is a .json
  • Remove necessity to start environment files with irods_environment

@chStaiger chStaiger linked an issue Nov 7, 2024 that may be closed by this pull request
GUI crashes when environment is not saved as .json #280
Closed
jelletreep
jelletreep reviewed Nov 7, 2024
View reviewed changes
ibridgesgui/login.py Outdated Show resolved Hide resolved
jelletreep
jelletreep reviewed Nov 7, 2024
View reviewed changes
Copy link
Contributor

@jelletreep jelletreep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! maybe also change the error message!

@chStaiger @jelletreep
Update ibridgesgui/login.py
41cfa6b 
Co-authored-by: Jelle Treep <40466121+jelletreep@users.noreply.github.com>
@chStaiger
Copy link
Collaborator Author

Thank you!!!

@chStaiger chStaiger merged commit 43e26e1 into develop Nov 7, 2024
7 checks passed
@chStaiger chStaiger deleted the config-editor branch November 7, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jelletreep jelletreep jelletreep left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GUI crashes when environment is not saved as .json
2 participants
@chStaiger @jelletreep