Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Saved topology updating #104

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

dbmkin
Copy link

@dbmkin dbmkin commented Jul 13, 2022

Comparing current topology with saved and asking to update. All new interfaces positioning on 0.0 coords.

Also added new field in "layout_context" to prevent fail when resaving topologies and deleting parent topology.

Comparing current topology with saved and asking to update. All new interfaces positioning on 0.0 coords
@iglagolev
Copy link

Hi. I tried to merge idebugall:master and dbmkin:adding_new_interfaces_to_saved locally.
I built nexbox with nextbox-ui-plugin and launched it via docker compose up. When trying to save the topology in the browser, it gives an error:

Uncaught ReferenceError: initialFilters is not defined
    at saveView (next_app.js:469:39)

I can't understand where it is defined initialFilters?
Here is my custom function:

'layout_context': JSON.stringify({
                    'initialLayout': initialLayout,
                    'displayUnconnected': !displayUnconnected,
                    'undisplayedRoles': undisplayedRoles,
                    'undisplayedDeviceTags': undisplayedDeviceTags,
                    'displayPassiveDevices': !displayPassiveDevices,
                    'displayLogicalMultiCableLinks': displayLogicalMultiCableLinks,
                    'requestGET': requestGET,
                    'initialFilters': initialFilters,
                })

Added initial_filters var
@dbmkin
Copy link
Author

dbmkin commented Jan 16, 2023

Hi. I tried to merge idebugall:master and dbmkin:adding_new_interfaces_to_saved locally. I built nexbox with nextbox-ui-plugin and launched it via docker compose up. When trying to save the topology in the browser, it gives an error:

Uncaught ReferenceError: initialFilters is not defined
    at saveView (next_app.js:469:39)

I can't understand where it is defined initialFilters? Here is my custom function:

'layout_context': JSON.stringify({
                    'initialLayout': initialLayout,
                    'displayUnconnected': !displayUnconnected,
                    'undisplayedRoles': undisplayedRoles,
                    'undisplayedDeviceTags': undisplayedDeviceTags,
                    'displayPassiveDevices': !displayPassiveDevices,
                    'displayLogicalMultiCableLinks': displayLogicalMultiCableLinks,
                    'requestGET': requestGET,
                    'initialFilters': initialFilters,
                })

I forgot to add this variable in template file at pull request. Check the commits, it should work correctly now.

@iglagolev
Copy link

Please note that this Pull request cannot be checked and run after commit: Install the plugin from PyPi
because the plugin installation sources have changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants