New feature: allow users to automatically skip certain days of the week #2012
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this, the user can select days of the week to be skipped automatically every week.
The use case I wrote this for is as follows: (closes #1980)
I have some tasks which I do only on working days and some tasks I do only on weekends/holidays. Therefore, I needed to automatically skip the weekend for some tasks and the working days for other tasks. To generalize it, any days of the week can be set for automatic skipping.
I added a new class, SkipDays, which is an attribute of the Habit class. It holds information on whether automatic skipping is turned on or off and which days of the week should be skipped. The skip days option is only available in the EditHabitAcitivity when it (isSkipEnabled) is enabled in preferences. It is also only enabled for daily and weekly habits. Auto-skipping days can be enabled in the edit habit activity. It uses the same weekday picker as the reminder to select the days to skip.
Auto skipping days affects the following:
If the auto-skip feature is turned on for a habit with already existing entries, the entries are not modified in any way. If there already exists entries on the now auto-skip days, then those entries are simply ignored.
The database version is bumped, and a new SQL file is added so that the update from the current version works.
I have also written some unit tests to test the streak and target card behavior with auto skip turned on.