iOS tests fix #7306
Merged
iOS tests fix #7306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Reenable iOS backend unit tests in CI * Copy test output XML instead of extracting from console log * Show error output if present when running display-test-app
tcobbs-bentley
requested review from
a team,
aruniverse,
calebmshafer,
wgoehrig,
bbastings and
ColinKerr
as code owners
aruniverse
reviewed
Oct 30, 2024
...-runner/core-test-runner.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Show resolved
Hide resolved
aruniverse
approved these changes
Oct 30, 2024
|
@Mergifyio backport release/4.9.x |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Oct 30, 2024
(cherry picked from commit 7fb3426) # Conflicts: # core/backend/runUnitTestsIosSimulator.ts # test-apps/display-test-app/runIosSimulator.ts
aruniverse
pushed a commit
that referenced
this pull request
Oct 31, 2024
Co-authored-by: Travis Cobbs <77415528+tcobbs-bentley@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
iOS tests fix:
Hopefully this will fix the CI test failures for the backend unit tests. Unfortunately, I have no idea what was causing the failures, but I no longer execute the code that appeared to be failing, so hopefully that fixes the problem. (Specifically, instead of printing the XML file contents to the console during execution, this now prints the XML filename, and that file is then copied to the appropriate place by the script running the iOS Simulator.)