Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate PresentationRpcInterface (backport #7319) [release/4.11.x] #7334

Merged
merged 4 commits into from
Nov 12, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Nov 7, 2024

We are planning to deprecate RPC altogether in the future, and while we don't have a replacement just yet, we can at least encourage people to use various wrappers instead of calling RPC interfaces directly. This way the transition to new APIs will be less disruptive. Presentation is the only RPC interface where all the methods are public and not internal.


This is an automatic backport of pull request #7319 done by Mergify.

Co-authored-by: Grigas <35135765+grigasp@users.noreply.github.com>
(cherry picked from commit 0990a56)

# Conflicts:
#	docs/changehistory/NextVersion.md
@mergify mergify bot added the conflicts label Nov 7, 2024
@mergify mergify bot requested a review from a team as a code owner November 7, 2024 09:44
Copy link
Contributor Author

mergify bot commented Nov 7, 2024

Cherry-pick of 0990a56 has failed:

On branch mergify/bp/release/4.11.x/pr-7319
Your branch is up to date with 'origin/release/4.11.x'.

You are currently cherry-picking commit 0990a56c24.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   common/api/presentation-common.api.md
	new file:   common/changes/@itwin/presentation-backend/deprecate-presentation-rpc_2024-11-06-13-28.json
	new file:   common/changes/@itwin/presentation-common/deprecate-presentation-rpc_2024-11-04-15-22.json
	modified:   full-stack-tests/presentation/src/rpc/PresentationRpcInterface.test.ts
	modified:   presentation/backend/src/presentation-backend/PresentationRpcImpl.ts
	modified:   presentation/backend/src/test/PresentationRpcImpl.test.ts
	modified:   presentation/common/src/presentation-common/PresentationRpcInterface.ts
	modified:   presentation/common/src/presentation-common/RpcRequestsHandler.ts
	modified:   presentation/common/src/test/PresentationRpcInterface.test.ts
	modified:   presentation/common/src/test/RpcRequestsHandler.test.ts

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   docs/changehistory/NextVersion.md

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify mergify bot requested review from grigasp and a team as code owners November 7, 2024 09:44
@mergify mergify bot requested a review from GerardasB November 7, 2024 09:44
@mergify mergify bot requested a review from MarcNeely November 7, 2024 09:44
@mergify mergify bot requested a review from a team November 7, 2024 09:44
@paulius-valiunas paulius-valiunas merged commit ba8f252 into release/4.11.x Nov 12, 2024
16 checks passed
@paulius-valiunas paulius-valiunas deleted the mergify/bp/release/4.11.x/pr-7319 branch November 12, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants