Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ECSql tests for ECDb (backport #7323) [release/4.10.x] #7537

Closed
wants to merge 1 commit into from

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jan 10, 2025

imodel-native: iTwin/imodel-native#937

Framework that makes it easier to compose a large amount of SQL tests which verify results (not just prepare and done).

Part of a shared effort to increase our ECDb test coverage after recent breaks.

Unbenannt

The picture separates our API into 9 areas which we can distribute among the team.

  • 1 - Subquery, ClassName, MemberFunctionCall, TableValuesFunction(Naron)
  • 2 - CommonTable Expressions (Soham)
  • 3 - Properties, LimitOffset, Group by, Having, Where, SubqueryTest, AllOrAny (Rohit)
  • 4- Joins(Naron)
  • 5- Pragma and NavValueCreation (Rohit)
  • 6 - Parameter, Boolean, Range (Akshay) (Under review: Rohit)
  • 7- Literals, EnumValue, ExtractValue( Soham)
  • 8 - Cast, PropertyNameList, SubqueryValue, IIF (Robert)
  • 9 - Window Functions (Robert)

This is an automatic backport of pull request #7323 done by [Mergify](https://mergify.com).

Co-authored-by: soham-bentley <177123878+soham-bentley@users.noreply.github.com>
Co-authored-by: RohitPtnkr1996 <111407262+RohitPtnkr1996@users.noreply.github.com>
Co-authored-by: naronchen <naronchen@users.noreply.github.com>
Co-authored-by: akshay05n <44081595+akshay05n@users.noreply.github.com>
Co-authored-by: Paul Connelly <22944042+pmconne@users.noreply.github.com>
Co-authored-by: imodeljs-admin <38288322+imodeljs-admin@users.noreply.github.com>
(cherry picked from commit 46b679a)

# Conflicts:
#	common/config/rush/pnpm-lock.yaml
#	core/backend/package.json
#	core/backend/src/test/ecdb/ECSqlReader.test.ts
#	test-apps/display-test-app/android/imodeljs-test-app/app/build.gradle
#	test-apps/display-test-app/ios/imodeljs-test-app/imodeljs-test-app.xcodeproj/project.pbxproj
#	tools/internal/ios/core-test-runner/core-test-runner.xcodeproj/project.pbxproj
Copy link
Contributor Author

mergify bot commented Jan 10, 2025

Cherry-pick of 46b679a has failed:

On branch mergify/bp/release/4.10.x/pr-7323
Your branch is up to date with 'origin/release/4.10.x'.

You are currently cherry-picking commit 46b679a54b.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	new file:   common/changes/@itwin/core-backend/rob-ecsql-tests_2024-12-13-11-28.json
	modified:   common/config/azure-pipelines/templates/core-build.yaml
	modified:   common/config/rush/browser-approved-packages.json
	new file:   core/backend/src/test/assets/ECSqlTests/AllProperties.ecschema.xml
	new file:   core/backend/src/test/ecsql/README.md
	new file:   core/backend/src/test/ecsql/dataset/ECSqlDatasets.ts
	new file:   core/backend/src/test/ecsql/queries/AllOrAnyExp.ecsql.md
	new file:   core/backend/src/test/ecsql/queries/BetweenRangeValue.ecsql.md
	new file:   core/backend/src/test/ecsql/queries/Binders.ecsql.md
	new file:   core/backend/src/test/ecsql/queries/Comparison.ecsql.md
	new file:   core/backend/src/test/ecsql/queries/CteTests.ecsql.md
	new file:   core/backend/src/test/ecsql/queries/DataTypes.ecsql.md
	new file:   core/backend/src/test/ecsql/queries/DerivedProperty.ecsql.md
	new file:   core/backend/src/test/ecsql/queries/EnumValueExpTests.ecsql.md
	new file:   core/backend/src/test/ecsql/queries/Examples.ecsql.md
	new file:   core/backend/src/test/ecsql/queries/ExtractInstance_ExtractProp.ecsql.md
	new file:   core/backend/src/test/ecsql/queries/FromClause.ecsql.md
	new file:   core/backend/src/test/ecsql/queries/GroupByClause.ecsql.md
	new file:   core/backend/src/test/ecsql/queries/JoinClause.ecsql.md
	new file:   core/backend/src/test/ecsql/queries/MemberFunction.ecsql.md
	new file:   core/backend/src/test/ecsql/queries/Misc.ecsql.md
	new file:   core/backend/src/test/ecsql/queries/NavValueCreationFunc.ecsql.md
	new file:   core/backend/src/test/ecsql/queries/OrderByClause.ecsql.md
	new file:   core/backend/src/test/ecsql/queries/ParameterExp.ecsql.md
	new file:   core/backend/src/test/ecsql/queries/RowFormat.ecsql.md
	new file:   core/backend/src/test/ecsql/queries/SearchClauseWhenExp.ecsql.md
	new file:   core/backend/src/test/ecsql/queries/SelectClause.ecsql.md
	new file:   core/backend/src/test/ecsql/queries/Subquery.ecsql.md
	new file:   core/backend/src/test/ecsql/queries/ValueExp.ecsql.md
	new file:   core/backend/src/test/ecsql/queries/WhereClause.ecsql.md
	new file:   core/backend/src/test/ecsql/queries/WindowFunctions.ecsql.md
	new file:   core/backend/src/test/ecsql/src/ECSqlTestGenerator.ts
	new file:   core/backend/src/test/ecsql/src/ECSqlTestParser.ts
	new file:   core/backend/src/test/ecsql/src/ECSqlTestRunner.test.ts
	modified:   core/backend/src/test/standalone/DisplayStyle.test.ts

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   common/config/rush/pnpm-lock.yaml
	both modified:   core/backend/package.json
	both modified:   core/backend/src/test/ecdb/ECSqlReader.test.ts
	both modified:   test-apps/display-test-app/android/imodeljs-test-app/app/build.gradle
	both modified:   test-apps/display-test-app/ios/imodeljs-test-app/imodeljs-test-app.xcodeproj/project.pbxproj
	both modified:   tools/internal/ios/core-test-runner/core-test-runner.xcodeproj/project.pbxproj

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify mergify bot mentioned this pull request Jan 10, 2025
9 tasks
@mergify mergify bot requested a review from a team January 10, 2025 15:19
@aruniverse aruniverse closed this Jan 10, 2025
@aruniverse aruniverse deleted the mergify/bp/release/4.10.x/pr-7323 branch January 10, 2025 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants