-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ci] Use pipeline to update gather-docs.yaml during releases #7546
Draft
DanRod1999
wants to merge
2
commits into
master
Choose a base branch
from
dan/gather-docs.yml-automation
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,38 @@ | ||
name: check-gather-docs | ||
trigger: none | ||
|
||
resources: | ||
pipelines: | ||
- pipeline: 'itwinjs' | ||
source: iTwin.js/iTwin.js | ||
trigger: | ||
enabled: true | ||
branches: | ||
include: | ||
- release/* | ||
tags: | ||
- 'package-release' | ||
|
||
jobs: | ||
- job: check-gather-docs | ||
displayName: 'Check and update gather-docs.yaml branch' | ||
pool: | ||
vmImage: 'ubuntu-latest' | ||
|
||
variables: | ||
- group: imodel-native-secret-variables | ||
|
||
steps: | ||
- checkout: self | ||
persistCredentials: true | ||
clean: true | ||
|
||
- script: | | ||
node common/scripts/check_gather_docs.mjs | ||
git add . | ||
git commit -m "Update gather-docs.yaml" | ||
git push --set-upstream https://$(GH_TOKEN)@github.com/iTwin/itwinjs-core $(Build.SourceBranchName) | ||
displayName: 'Check gather-docs.yaml branch' | ||
env: | ||
GITHUB_TOKEN: $(GH_TOKEN) | ||
CURRENT_BRANCH: $(Build.SourceBranch) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,70 @@ | ||
import fs from "fs"; | ||
import path from "path"; | ||
|
||
function checkFile(filePath, currentBranch) { | ||
// const filePath = path.normalize("./common/config/azure-pipelines/templates/gather-docs.yaml") | ||
if (!fs.existsSync(filePath)) { | ||
console.error("File not found."); | ||
process.exit(1); | ||
} | ||
|
||
const fileContent = fs.readFileSync(filePath, "utf8"); | ||
|
||
const textToFind = /branchName: refs\/heads\/release\/\d+\.\d+\.x/gi; | ||
const branchInFile = fileContent.match(textToFind); | ||
|
||
if (!branchInFile) { | ||
console.error("No match for branch name found"); | ||
process.exit(1); | ||
} | ||
|
||
if (branchInFile[0] === `branchName: ${currentBranch}`) { | ||
console.log("The current branch matches the branch in gather-docs.yaml. No update Needed."); | ||
return false; | ||
} | ||
else { | ||
const newContent = fileContent.replace(textToFind, `branchName: ${currentBranch}`); | ||
fs.writeFileSync(filePath, newContent, "utf8"); | ||
console.log("Updated gather-docs.yaml with the current branch."); | ||
return true; | ||
} | ||
} | ||
|
||
function main() { | ||
const filePath = path.normalize("./common/config/azure-pipelines/templates/gather-docs.yaml") | ||
const currentBranch = process.env.CURRENT_BRANCH; | ||
checkFile(filePath, currentBranch); | ||
} | ||
main(); | ||
|
||
// Tests | ||
function createTempFile(name, content) { | ||
const tempFilePath = path.join('./', `${name}`); | ||
|
||
fs.writeFileSync(tempFilePath, content, "utf8"); | ||
console.log(`Temporary file created at: ${tempFilePath}`); | ||
|
||
return tempFilePath; | ||
} | ||
|
||
function deleteTempFile(filePath) { | ||
if (fs.existsSync(filePath)) { | ||
fs.unlinkSync(filePath); | ||
console.log(`Temporary file deleted: ${filePath}`); | ||
} else { | ||
console.log(`File not found: ${filePath}`); | ||
} | ||
} | ||
|
||
function tests() { | ||
const currentBranch = "refs/heads/release/1.2.x"; | ||
// Test for when file needs to be updated | ||
let filePath = createTempFile("should-change.txt", "branchName: refs/heads/release/0.0.x"); | ||
console.assert(checkFile(filePath, currentBranch) === true, "File should be updated"); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Maybe should check that the file contains the proper branch 'branchName: refs/heads/release/1.2.x' |
||
deleteTempFile(filePath); | ||
|
||
filePath = createTempFile("should-not-change.txt", "branchName: refs/heads/release/1.2.x"); | ||
console.assert(checkFile(filePath, currentBranch) === false, "File should not be updated"); | ||
deleteTempFile(filePath); | ||
} | ||
// tests(); |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we also add a quick sanity check here to make sure the new branchName also follows 'refs/heads/release/\d+.\d+.x/gi' before we update it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea, this should be an easy way to make sure its not master branch or something