Remove deprecated 3.x APIs in core-common

core/common/src/Code.ts

@@ -333,17 +333,4 @@ export class CodeSpec {
     else
       this.properties.scopeSpec.fGuidRequired = undefined;
   }
-
-  /** Will be true if the codes associated with this CodeSpec are managed along with the iModel and false if the codes are managed by an external service.
-   * @deprecated in 3.6 Use scopeReq instead.
-   */
-  public get isManagedWithIModel(): boolean {
-    return this.properties.spec?.isManagedWithDgnDb ?? true;
-  }
-  public set isManagedWithIModel(value: boolean) {
-    if (!this.properties.spec)
-      this.properties.spec = {};
-
-    this.properties.spec.isManagedWithDgnDb = value;
-  }
 }

core/common/src/FeatureSymbology.ts

@@ -817,42 +817,6 @@ export class FeatureOverrides implements FeatureAppearanceSource {
     map.set(idLo, idHi, app);
   }
 
-  /** Specify overrides for all elements within the specified model.
-   * @param id The Id of the model.
-   * @param app The symbology overrides.
-   * @param replaceExisting Specifies whether to replace a pre-existing override for the same model.
-   * @note These overrides take priority over all other overrides.
-   * @note If [[defaultOverrides]] are defined, they will not apply to any element within this model, even if the supplied appearance overrides nothing.
-   * @deprecated in 3.x. Use [[FeatureOverrides.override]].
-   */
-  public overrideModel(id: Id64String, app: FeatureAppearance, replaceExisting: boolean = true): void {
-    this.override({ modelId: id, appearance: app, onConflict: replaceExisting ? "replace" : "skip" });
-  }
-
-  /** Specify overrides for all geometry belonging to the specified [SubCategory]($backend).
-   * @param id The Id of the subcategory.
-   * @param app The symbology overrides.
-   * @param replaceExisting Specifies whether to replace a pre-existing override for the same subcategory.
-   * @note These overrides have lower priority than element and model overrides.
-   * @note If [[defaultOverrides]] are defined, they will not apply to any geometry within this subcategory, even if the supplied appearance overrides nothing.
-   * @deprecated in 3.x. Use [[FeatureOverrides.override]].
-   */
-  public overrideSubCategory(id: Id64String, app: FeatureAppearance, replaceExisting: boolean = true): void {
-    this.override({ subCategoryId: id, appearance: app, onConflict: replaceExisting ? "replace" : "skip" });
-  }
-
-  /** Specify overrides for all geometry originating from the specified element.
-   * @param id The Id of the element.
-   * @param app The symbology overrides.
-   * @param replaceExisting Specifies whether to replace a pre-existing override for the same element.
-   * @note These overrides take precedence over subcategory overrides, but not over model overrides.
-   * @note If [[defaultOverrides]] are defined, they will not apply to this element, even if the supplied appearance overrides nothing.
-   * @deprecated in 3.x. Use [[FeatureOverrides.override]].
-   */
-  public overrideElement(id: Id64String, app: FeatureAppearance, replaceExisting: boolean = true): void {
-    this.override({ elementId: id, appearance: app, onConflict: replaceExisting ? "replace" : "skip" });
-  }
-
   /** Specify overrides for all geometry originating from the specified animation node.
    * @param id The Id of the animation node.
    * @param app The symbology overrides.

core/common/src/Localization.ts

@@ -60,15 +60,6 @@ export interface Localization {
    * @throws Error if no keys resolve to a string.
    */
   getLocalizedString(key: string | string[], options?: TranslationOptions): string;
-  /** Similar to `getLocalizedString` but the namespace is a separate param and the key does not include the namespace.
-   * @param namespace - the namespace that identifies the particular localization file that contains the property.
-   * @param key - the key that matches a property in the JSON localization file.
-   * @returns The string corresponding to the first key that resolves.
-   * @throws Error if no keys resolve to a string.
-   * @deprecated in 3.x. Use `getLocalizedString` instead; providing either a key with a namespace `<namespace>:<key>` or
-   * including `{ ns: <namespace> }` in the options.
-   */
-  getLocalizedStringWithNamespace(namespace: string, key: string | string[], options?: TranslationOptions): string;
   /** get the English string for a key. */
   getEnglishString(namespace: string, key: string | string[], options?: TranslationOptions): string;
   /** Replace all instances of `%{key}` within a string with the translations of those keys.

core/common/src/RenderMaterial.ts

@@ -7,7 +7,6 @@
  */
 
 import { compareStrings, Guid, GuidString } from "@itwin/core-bentley";
-import { ColorDef } from "./ColorDef";
 import { TextureMapping } from "./TextureMapping";
 
 /** Represents a material which can be applied to a surface to control aspects of its appearance such as color, reflectivity, texture, and so on.
@@ -36,71 +35,3 @@ export abstract class RenderMaterial {
     return compareStrings(this._guid, other._guid);
   }
 }
-
-/** @public */
-export namespace RenderMaterial {
-  function clampToNormalizedRange(value: number): number {
-    return Math.max(0.0, Math.min(1.0, value));
-  }
-
-  /** @deprecated in 3.x. Use [CreateRenderMaterialArgs]($frontend). */
-  export class Params {
-    /** If the material originates from a Material element in the [[IModel]], the Id of that element. */
-    public key?: string;
-    /** Diffuse color, or undefined if this material does not override the surface's own color. */
-    public diffuseColor?: ColorDef;
-    /** Specular color. Defaults to white if undefined. */
-    public specularColor?: ColorDef;
-    /** Currently unused. @alpha */
-    public emissiveColor?: ColorDef;
-    /** Currently unused. @alpha */
-    public reflectColor?: ColorDef;
-    /** Optional pattern mapping applied to the surface. */
-    public textureMapping?: TextureMapping;
-    /** Diffuse weight in [0..1] */
-    public diffuse: number = 0.6;
-    /** Specular weight in [0..1] */
-    public specular: number = 0.4;
-    public specularExponent: number = 13.5;
-    /** Currently unused. @alpha */
-    public reflect: number = 0.0;
-    /** Currently unused. @alpha */
-    public refract: number = 1.0;
-    /** Currently unused. @alpha */
-    public ambient: number = .3;
-    /** Currently unused. @alpha */
-    public shadows = true;
-    private _alpha?: number;
-
-    public constructor(key?: string) { this.key = key; }
-
-    /** Obtain an immutable instance of a RenderMaterial with all default properties. */
-    // eslint-disable-next-line @typescript-eslint/no-deprecated
-    public static readonly defaults = new Params();
-
-    /** A value from 0.0 (fully-transparent) to 1.0 (fully-opaque) controlling the transparency of surfaces to which this material is applied;
-     * or undefined if this material does not override surface transparency.
-     */
-    public get alpha(): number | undefined { return this._alpha; }
-    public set alpha(alpha: number | undefined) {
-      this._alpha = undefined !== alpha ? clampToNormalizedRange(alpha) : undefined;
-    }
-
-    /** Create a RenderMaterial params object using specified key and ColorDef values, as well as an optional texture mapping. */
-    // eslint-disable-next-line @typescript-eslint/no-deprecated
-    public static fromColors(key?: string, diffuseColor?: ColorDef, specularColor?: ColorDef, emissiveColor?: ColorDef, reflectColor?: ColorDef, textureMap?: TextureMapping): Params {
-      // eslint-disable-next-line @typescript-eslint/no-deprecated
-      const materialParams = new Params();
-      materialParams.key = key;
-      materialParams.diffuseColor = diffuseColor;
-      materialParams.specularColor = specularColor;
-      materialParams.emissiveColor = emissiveColor;
-      materialParams.reflectColor = reflectColor;
-      materialParams.textureMapping = textureMap;
-      return materialParams;
-    }
-  }
-}
-
-// eslint-disable-next-line @typescript-eslint/no-deprecated
-Object.freeze(RenderMaterial.Params.defaults);

core/common/src/RenderTexture.ts

@@ -68,31 +68,4 @@ export namespace RenderTexture {
     /** A gradient image used for thematic display. */
     ThematicGradient,
   }
-
-  /** Parameters used to construct a [[RenderTexture]].
-   * @deprecated in 3.x. use RenderSystem.createTexture and CreateTextureArgs.
-   * @public
-   */
-  export class Params {
-    /** A string uniquely identifying this texture within the context of an [[IModel]]. Typically this is the element Id of the corresponding [Texture]($backend) element.
-     * Textures created on the front-end generally have no key.
-     */
-    public readonly key?: string;
-    /** Indicates the type of texture. */
-    public readonly type: RenderTexture.Type;
-    /** Indicates that some object is managing the lifetime of this texture and will take care of calling its dispose function appropriately.
-     * An unowned texture associated with a [RenderGraphic]($frontend) will be disposed when the RenderGraphic is disposed.
-     */
-    public readonly isOwned: boolean;
-
-    public constructor(key?: string, type: RenderTexture.Type = RenderTexture.Type.Normal, isOwned: boolean = false) {
-      this.key = key;
-      this.type = type;
-      this.isOwned = isOwned;
-    }
-
-    public get isTileSection(): boolean { return RenderTexture.Type.TileSection === this.type; }
-    public get isGlyph(): boolean { return RenderTexture.Type.Glyph === this.type; }
-    public get isSkyBox(): boolean { return RenderTexture.Type.SkyBox === this.type; }
-  }
 }

core/common/src/TerrainSettings.ts

@@ -8,14 +8,6 @@
 
 import { BackgroundMapProps } from "./BackgroundMapSettings";
 
-/** Identifies a [TerrainProvider]($frontend).
- * @see [[TerrainSettings.providerName]] and [[TerrainProps.providerName]].
- * @public
- * @extensions
- * @deprecated in 3.x. Use string instead.
- */
-export type TerrainProviderName = string;
-
 /** Ids of [Cesium ION assets](https://cesium.com/platform/cesium-ion/content/) providing global terrain data.
  * These values are appropriate to use with [[TerrainSettings.dataSource]] when [[TerrainSettings.providerName]] is set to "CesiumWorldTerrain".
  * You may alternatively use the Id of any ION asset to which you have access.

core/common/src/ViewProps.ts

@@ -71,8 +71,6 @@ export interface SubCategoryResultRow {
 export interface HydrateViewStateRequestProps {
   acsId?: string;
   notLoadedModelSelectorStateModels?: CompressedId64Set;
-  /** @deprecated in 3.x. If loading categoryIds is necessary, see [IModelConnection.SubCategoriesCache.load]($frontend)*/
-  notLoadedCategoryIds?: CompressedId64Set;
   sheetViewAttachmentIds?: CompressedId64Set;
   viewStateLoadProps?: ViewStateLoadProps;
   baseModelId?: Id64String;
@@ -90,8 +88,6 @@ export interface HydrateViewStateResponseProps {
   sheetViewViews?: (ViewStateProps | undefined)[];
   baseModelProps?: ModelProps;
   spatialViewProps?: ViewStateProps;
-  /** @deprecated in 3.x. If loading categoryIds is necessary, see [IModelConnection.SubCategoriesCache.load]($frontend)*/
-  categoryIdsResult?: SubCategoryResultRow[];
 }
 
 /** Returned from [IModelDb.Views.getViewStateData]($backend).

core/common/src/rpc/IModelReadRpcInterface.ts

@@ -115,8 +115,6 @@ export abstract class IModelReadRpcInterface extends RpcInterface {
   public async getViewStateData(_iModelToken: IModelRpcProps, _viewDefinitionId: string, _options?: ViewStateLoadProps): Promise<ViewStateProps> { return this.forward(arguments); }
   public async readFontJson(_iModelToken: IModelRpcProps): Promise<FontMapProps> { return this.forward(arguments); } // eslint-disable-line @typescript-eslint/no-deprecated
   public async getToolTipMessage(_iModelToken: IModelRpcProps, _elementId: string): Promise<string[]> { return this.forward(arguments); }
-  /** @deprecated in 3.x use ViewStore apis. */
-  public async getViewThumbnail(_iModelToken: IModelRpcProps, _viewId: string): Promise<Uint8Array> { return this.forward(arguments); }
   @RpcOperation.allowResponseCaching(RpcResponseCacheControl.Immutable)
   public async getDefaultViewId(_iModelToken: IModelRpcProps): Promise<Id64String> { return this.forward(arguments); }
   @RpcOperation.allowResponseCaching(RpcResponseCacheControl.Immutable)

docs/changehistory/NextVersion.md

@@ -19,11 +19,7 @@ Table of contents:
     - [Node.js](#nodejs)
     - [Electron](#electron)
     - [ECMAScript](#ecmascript)
-  - [Deprecated API removals](#deprecated-api-removals)
-    - [@itwin/core-backend](#itwincore-backend-1)
-    - [@itwin/core-bentley](#itwincore-bentley)
-    - [@itwin/appui-abstract](#itwinappui-abstract)
-    - [@itwin/core-electron](#itwincore-electron)
+  - [Deprecated API removals](#deprecated-api-removals) - [@itwin/core-backend](#itwincore-backend-1) - [@itwin/core-common](#itwincore-common-1) - [@itwin/core-bentley](#itwincore-bentley) - [@itwin/appui-abstract](#itwinappui-abstract) - [@itwin/core-electron](#itwincore-electron)
   - [API removals](#api-removals)
   - [Packages dropped](#packages-dropped)
 - [Change to pull/merge method](#change-to-pullmerge)
@@ -110,6 +106,19 @@ The following previously-deprecated APIs have been removed:
 
 All three `nativeDb` fields and `IModelHost.platform` have always been `@internal`. Use the `@public` APIs instead. If some functionality is missing from those APIs, [let us know](https://github.com/iTwin/itwinjs-core/issues/new?template=feature_request.md).
 
+#### @itwin/core-common
+
+| Removed                                        | Replacement                                          |
+| ---------------------------------------------- | ---------------------------------------------------- |
+| `CodeSpec.isManagedWithIModel`                 | `CodeSpec.scopeReq`                                  |
+| `FeatureOverrides.overrideModel`               | `FeatureOverrides.override`                          |
+| `FeatureOverrides.overrideSubCategory`         | `FeatureOverrides.override`                          |
+| `FeatureOverrides.overrideElement`             | `FeatureOverrides.override`                          |
+| `Localization.getLocalizedStringWithNamespace` | `Localization.getLocalizedString`                    |
+| `TerrainProviderName`                          | N/A                                                  |
+| `RenderMaterial.Params`                        | `CreateRenderMaterialArgs`                           |
+| `RenderTexture.Params`                         | `RenderSystem.createTexture` and `CreateTextureArgs` |
+
 #### @itwin/core-bentley
 
 | Removed                    | Replacement                                                 |