Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ECSql tests for ECDb (#7323) #7583

Merged
merged 11 commits into from
Jan 23, 2025

Conversation

soham-bentley
Copy link
Contributor

This is a manual backport of PR #7323 into release/4.11.x
A part of the #7323 PR is backported with another PR #7540
The remaining PR is backported with this PR

rschili and others added 2 commits January 10, 2025 15:18
Co-authored-by: soham-bentley <177123878+soham-bentley@users.noreply.github.com>
Co-authored-by: RohitPtnkr1996 <111407262+RohitPtnkr1996@users.noreply.github.com>
Co-authored-by: naronchen <naronchen@users.noreply.github.com>
Co-authored-by: akshay05n <44081595+akshay05n@users.noreply.github.com>
Co-authored-by: Paul Connelly <22944042+pmconne@users.noreply.github.com>
Co-authored-by: imodeljs-admin <38288322+imodeljs-admin@users.noreply.github.com>
(cherry picked from commit 46b679a)

# Conflicts:
#	common/config/rush/pnpm-lock.yaml
#	core/backend/package.json
#	test-apps/display-test-app/android/imodeljs-test-app/app/build.gradle
#	test-apps/display-test-app/ios/imodeljs-test-app/imodeljs-test-app.xcodeproj/project.pbxproj
#	tools/internal/ios/core-test-runner/core-test-runner.xcodeproj/project.pbxproj
…release/4.11.x/pr-7323

# Conflicts:
#	core/backend/package.json
#	test-apps/display-test-app/android/imodeljs-test-app/app/build.gradle
#	test-apps/display-test-app/ios/imodeljs-test-app/imodeljs-test-app.xcodeproj/project.pbxproj
#	tools/internal/ios/core-test-runner/core-test-runner.xcodeproj/project.pbxproj
@mergify mergify bot requested a review from a team January 22, 2025 07:26
@rschili
Copy link
Contributor

rschili commented Jan 22, 2025

Did we decide to backport this? I was under the impression we don’t want to do this. It’s a rather big PR which affects dependencies and builds. Just a week back I told Arun we’d not backport this

@soham-bentley
Copy link
Contributor Author

Did we decide to backport this? I was under the impression we don’t want to do this. It’s a rather big PR which affects dependencies and builds. Just a week back I told Arun we’d not backport this

Colin told me to backport it

@ColinKerr
Copy link
Member

Did we decide to backport this? I was under the impression we don’t want to do this. It’s a rather big PR which affects dependencies and builds. Just a week back I told Arun we’d not backport this

Colin told me to backport it

We will be back porting future ECDb changes to 4.x so ECDb changes propagate to all supported versions faster. Just like we did with 3.x. I want as much testing on 4.x as possible and new changes in 5.x will likely have tests using this framework

@soham-bentley soham-bentley enabled auto-merge (squash) January 23, 2025 18:33
@mergify mergify bot requested a review from a team January 23, 2025 18:36
@soham-bentley soham-bentley merged commit 8d197c5 into release/4.11.x Jan 23, 2025
16 checks passed
@soham-bentley soham-bentley deleted the mergify/bp/release/4.11.x/pr-7323 branch January 23, 2025 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants