Skip to content

Commit

Permalink
[FIX] Fixed a major bug that prevented the app from requesting permis…
Browse files Browse the repository at this point in the history
…sions on `Android 11/12.`

[CHORE] Updated dependencies to latest version.
  • Loading branch information
iZakirSheikh committed Sep 25, 2024
1 parent be2bb42 commit 5bc9839
Show file tree
Hide file tree
Showing 8 changed files with 22 additions and 16 deletions.
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -14,3 +14,4 @@
.cxx
local.properties
.kotlin
/app/crowdin.yml
8 changes: 4 additions & 4 deletions .idea/deploymentTargetSelector.xml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions app/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@ android {
applicationId = "com.googol.android.apps.photos"
minSdk = 24
targetSdk = 35
versionCode = 24
versionName = "1.0.0-alpha01"
versionCode = 25
versionName = "1.0.0-alpha02"

testInstrumentationRunner = "androidx.test.runner.AndroidJUnitRunner"
vectorDrawables {
Expand Down
1 change: 1 addition & 0 deletions app/src/main/AndroidManifest.xml
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
<uses-permission
android:name="android.permission.WRITE_EXTERNAL_STORAGE"
android:maxSdkVersion="30" />
<uses-permission android:name="android.permission.READ_EXTERNAL_STORAGE" android:maxSdkVersion="32" />

<!-- Devices running Android 13 (API level 33) or higher -->
<uses-permission android:name="android.permission.READ_MEDIA_IMAGES" />
Expand Down
3 changes: 3 additions & 0 deletions app/src/main/java/com/zs/gallery/Gallery.kt
Original file line number Diff line number Diff line change
Expand Up @@ -202,6 +202,9 @@ private val REQUIRED_PERMISSIONS = buildList {
// legacy storage access
if (Build.VERSION.SDK_INT <= Build.VERSION_CODES.Q)
this += android.Manifest.permission.WRITE_EXTERNAL_STORAGE
if (Build.VERSION.SDK_INT <= Build.VERSION_CODES.S_V2) {
this += android.Manifest.permission.READ_EXTERNAL_STORAGE
}
}

private object RoutePermission : Route
Expand Down
2 changes: 1 addition & 1 deletion app/src/main/res/values/what_s_new.xml
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,9 @@
<string name="what_s_new_latest" translatable="false">
<b>What\'s new</b>
<font color='grey'>
\n🐞 Fixed a major bug that prevented the app from requesting permissions on Android 11/12.
\n🎥 Enjoy seamless <b>video playback</b> with our new in-app <b>media player!</b>
\n✨<b>Toasts</b> &amp; <b>Snackbars</b> got a boost! Swipe to dismiss, expand for more info, and enjoy smoother interactions.
\n🐞 Various bug fixes and performance improvements.
\n\n<b>In Focus</b>
\n ⦿ General performance improvements
\n ⦿ Support for various file types: <b>GIF, SVG,</b> etc.
Expand Down
1 change: 1 addition & 0 deletions crowdin.yml
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@

files:
- source: /app/src/main/res/values/strings.xml
translation: /app/src/main/res/values/%two_letters_code%/%original_file_name%
18 changes: 9 additions & 9 deletions gradle/libs.versions.toml
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
[versions]
agp = "8.6.0"
agp = "8.6.1"
kotlin = "2.0.20"
compose = "1.8.0-alpha01"
compose = "1.8.0-alpha02"
media3 = "1.4.1"
toolkit = "2.0.2-rc02"
material_icons = "1.7.0"
material_icons = "1.7.2"

[plugins]
android-application = { id = "com.android.application", version.ref = "agp" }
Expand All @@ -22,18 +22,18 @@ androidx-exifinterface = { module = "androidx.exifinterface:exifinterface", vers
androidx-ui = { group = "androidx.compose.ui", name = "ui", version.ref = "compose" }
androidx-ui-graphics = { group = "androidx.compose.ui", name = "ui-graphics", version.ref = "compose" }
androidx-material = { module = "androidx.compose.material:material", version.ref = "compose" }
androidx-ui-text-google-fonts = { module = "androidx.compose.ui:ui-text-google-fonts", version = "1.7.0" }
androidx-ui-text-google-fonts = { module = "androidx.compose.ui:ui-text-google-fonts", version = "1.7.2" }
coil-compose = { module = "io.coil-kt:coil-compose", version = "2.7.0" }
firebase-analytics-ktx = { module = "com.google.firebase:firebase-analytics-ktx", version = "22.1.0" }
firebase-crashlytics-ktx = { module = "com.google.firebase:firebase-crashlytics-ktx", version = "19.0.3" }
firebase-crashlytics-ktx = { module = "com.google.firebase:firebase-crashlytics-ktx", version = "19.1.0" }
toolkit-core-ktx = { module = "com.github.prime-zs.toolkit:core-ktx", version.ref = "toolkit" }
toolkit-material2 = { module = "com.github.prime-zs.toolkit:material2", version.ref = "toolkit" }
navigation-compose = { module = "androidx.navigation:navigation-compose", version = "2.8.0" }
navigation-compose = { module = "androidx.navigation:navigation-compose", version = "2.8.1" }
toolkit-preferences = { module = "com.github.prime-zs.toolkit:preferences", version.ref = "toolkit" }
androidx-koin = { module = "io.insert-koin:koin-androidx-compose", version = "3.5.6" }
androidx-koin = { module = "io.insert-koin:koin-androidx-compose", version = "4.0.0" }
ui-tooling = { module = "androidx.compose.ui:ui-tooling", version.ref = "compose" }
ui-tooling-preview = { module = "androidx.compose.ui:ui-tooling-preview", version.ref = "compose" }
kotlinx-coroutines-android = { module = "org.jetbrains.kotlinx:kotlinx-coroutines-android", version = "1.8.1" }
kotlinx-coroutines-android = { module = "org.jetbrains.kotlinx:kotlinx-coroutines-android", version = "1.9.0" }
androidx-annotation-jvm = { group = "androidx.annotation", name = "annotation-jvm", version = "1.8.2" }

androidx-material-icons-core = { module = "androidx.compose.material:material-icons-core", version.ref = "material_icons" }
Expand All @@ -50,7 +50,7 @@ androidx-espresso-core = { group = "androidx.test.espresso", name = "espresso-co
androidx-window = { group = "androidx.window", name = "window", version = "1.3.0" }
androidx-activity-compose = { group = "androidx.activity", name = "activity-compose", version = "1.9.2" }
androidx-core-splashscreen = { module = "androidx.core:core-splashscreen", version = "1.0.1" }
androidx-startup-runtime = { module = "androidx.startup:startup-runtime", version = "1.1.1" }
androidx-startup-runtime = { module = "androidx.startup:startup-runtime", version = "1.2.0" }
lottie-compose = { module = "com.airbnb.android:lottie-compose", version = "6.5.2" }
saket-zoomable = { module = "me.saket.telephoto:zoomable", version = "0.13.0" }
play-app-update-ktx = { module = "com.google.android.play:app-update-ktx", version = "2.1.0" }
Expand Down

0 comments on commit 5bc9839

Please sign in to comment.