Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client: beautify subtask score alignment for decimal score #655

Merged
merged 1 commit into from
Aug 25, 2024
Merged

client: beautify subtask score alignment for decimal score #655

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 21 additions & 5 deletions judgels-client/src/components/SubmissionDetails/Programming/SubmissionDetails.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,15 +92,31 @@ export function SubmissionDetails({
};

const renderScore = score => {
let formattedScore = score;

if (score.startsWith('*')) {
return '✓' + score.substring(1);
}
if (score.startsWith('X')) {
return '✕' + score.substring(1);
formattedScore = '✓' + score.substring(1);
} else if (score.startsWith('X')) {
formattedScore = '✕' + score.substring(1);
}
return score;
};

const renderSubtaskScore = score => {
if (Number.isInteger(score)) {
return <span className="subtask-score">{score}</span>;
}

const integer = Math.trunc(score);
const decimal = (score - integer).toString().replace('0.', '.');
return (
<>
<span className="subtask-score">{integer}</span>
<span className="subtask-score">{decimal}</span>
</>
);
};

const renderSubtaskResults = () => {
if (!hasSubtasks) {
return null;
Expand All @@ -115,7 +131,7 @@ export function SubmissionDetails({
<span className="subtask-verdict">
<VerdictTag verdictCode={subtaskResult.verdict.code} />
</span>
<span className="subtask-score">{subtaskResult.score}</span>
{renderSubtaskScore(subtaskResult.score)}
</h5>
</summary>

Expand Down
Loading