added elementsAreUnique() validator

ia-toki · Oct 17, 2024 · b839ee6 · b839ee6
1 parent c9aa252
commit b839ee6
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 8 deletions.
diff --git a/include/tcframe/validator/vector.hpp b/include/tcframe/validator/vector.hpp
@@ -54,14 +54,11 @@ bool elementsAreAscending(const vector<T> &v) {
     return true;
 }
 
-template<typename T, typename Compare>
-bool elementsAreOrdered(const vector<T> &v, Compare comp) {
-    for (std::size_t i = 1; i < v.size(); ++i) {
-        if(!comp(v[i - 1], v[i])) {
-            return false;
-        }
-    }
-    return true;
+template<typename T>
+bool elementsAreUnique(vector<T> v) {
+    sort(v.begin(), v.end());
+    std::size_t ns = unique(v.begin(), v.end()) - v.begin();
+    return ns == v.size();
 }
 
 }
diff --git a/test/unit/tcframe/validator/VectorValidatorTests.cpp b/test/unit/tcframe/validator/VectorValidatorTests.cpp
@@ -49,4 +49,12 @@ TEST_F(VectorValidatorTests, elementsAreAscending) {
     EXPECT_TRUE(elementsAreAscending(vector<int>{1, 2, 3, 4, 5}));
 }
 
+TEST_F(VectorValidatorTests, elementsAreUnique) {
+    EXPECT_FALSE(elementsAreUnique(vector<int>{5, 1, 3, 4, 2, 1}));
+    EXPECT_FALSE(elementsAreUnique(vector<char>{'a', 'c', 'f', 'f', 'd'}));
+    EXPECT_TRUE(elementsAreUnique(vector<int>()));
+    EXPECT_TRUE(elementsAreUnique(vector<int>{5, 2, 4, 1, 9}));
+    EXPECT_TRUE(elementsAreUnique(vector<char>{'a', 'x', 'd', 'g', 'h'}));
+}
+
 }