Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validator: refactor number validators to core #199

Merged
merged 1 commit into from
Oct 28, 2024
Merged

Validator: refactor number validators to core #199

merged 1 commit into from
Oct 28, 2024

Conversation

fushar
Copy link
Member

@fushar fushar commented Oct 27, 2024 •
edited
Loading

@fushar fushar force-pushed the refactor-number-validator branch from 163f650 to 908c8fe Compare October 27, 2024 08:31
@fushar fushar marked this pull request as ready for review October 27, 2024 08:38
@fushar fushar requested a review from JoelGunawan October 27, 2024 08:38
@fushar fushar force-pushed the refactor-number-validator branch 2 times, most recently from f1fb984 to aa26ed9 Compare October 27, 2024 08:48
@fushar fushar force-pushed the refactor-number-validator branch from aa26ed9 to 0cb2935 Compare October 27, 2024 08:56
@fushar fushar self-assigned this Oct 27, 2024
JoelGunawan
JoelGunawan approved these changes Oct 27, 2024
View reviewed changes
Copy link
Collaborator

@JoelGunawan JoelGunawan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fushar fushar merged commit 16cab14 into master Oct 28, 2024
3 checks passed
@fushar fushar deleted the refactor-number-validator branch October 28, 2024 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoelGunawan JoelGunawan JoelGunawan approved these changes

Assignees

@fushar fushar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fushar @JoelGunawan