Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/217-Neural-based-dialogue-policies #218

Merged
merged 9 commits into from
Oct 25, 2023
Merged

Feature/217-Neural-based-dialogue-policies #218

merged 9 commits into from
Oct 25, 2023

Conversation

NoB0
Copy link
Contributor

@NoB0 NoB0 commented Sep 18, 2023

Add neural policies: DQN and A2C.

@NoB0 NoB0 linked an issue Sep 18, 2023 that may be closed by this pull request
Neural based dialogue policies #217
Closed
@github-actions
Copy link

Current Branch Main Branch
Coverage Badge Coverage Badge

@NoB0 NoB0 marked this pull request as ready for review October 17, 2023 16:53
@NoB0 NoB0 requested a review from WerLaj October 18, 2023 07:10
WerLaj
WerLaj reviewed Oct 23, 2023
View reviewed changes
Copy link
Contributor

@WerLaj WerLaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some clarifications are requested

moviebot/dialogue_manager/dialogue_policy/neural_dialogue_policy.py Outdated Show resolved Hide resolved
moviebot/dialogue_manager/dialogue_policy/neural_dialogue_policy.py Show resolved Hide resolved
moviebot/dialogue_manager/dialogue_policy/neural_dialogue_policy.py Outdated Show resolved Hide resolved
moviebot/dialogue_manager/dialogue_policy/neural_dialogue_policy.py Show resolved Hide resolved
moviebot/dialogue_manager/dialogue_policy/dqn_dialogue_policy.py Show resolved Hide resolved
moviebot/dialogue_manager/dialogue_policy/dqn_dialogue_policy.py Show resolved Hide resolved
moviebot/dialogue_manager/dialogue_policy/a2c_dialogue_policy.py Outdated Show resolved Hide resolved
moviebot/dialogue_manager/dialogue_policy/a2c_dialogue_policy.py Outdated Show resolved Hide resolved
tests/dialogue_manager/test_dialogue_policy.py Show resolved Hide resolved
@NoB0 NoB0 requested a review from WerLaj October 24, 2023 14:24
WerLaj
WerLaj approved these changes Oct 24, 2023
View reviewed changes
Copy link
Contributor

@WerLaj WerLaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with one comment to address. Thank you for clarifications.

moviebot/dialogue_manager/dialogue_policy/neural_dialogue_policy.py Outdated Show resolved Hide resolved
@NoB0 NoB0 merged commit 908cdf2 into main Oct 25, 2023
4 checks passed
@NoB0 NoB0 deleted the feature/217-Neural-based-dialogue-policies branch October 25, 2023 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WerLaj WerLaj WerLaj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Neural based dialogue policies
2 participants
@NoB0 @WerLaj