Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add backend for population management #56

Open
wants to merge 33 commits into
base: main
Choose a base branch
from
Open

Add backend for population management #56

wants to merge 33 commits into from

Conversation

NoB0
Copy link
Collaborator

@NoB0 NoB0 commented Dec 13, 2023 •
edited
Loading

Implement endpoints to add and delete statements.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 13, 2023 •
edited
Loading

Unit Test Results

63 tests   63 ✔️  8s ⏱️
  1 suites    0 💤
  1 files      0 ❌

Results for commit 5f15c71.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 13, 2023 •
edited
Loading

Coverage Report •
FileStmtsMissCoverMissing
conftest.py00100% 
pkg_api
   connector.py350100% 
pkg_api/server
   \_\_init\_\_.py30388%36–38
   pkg_exploration.py260100% 
   statements_management.py31487%35–36, 60–61
   utils.py39582%82–85, 102, 112
tests/pkg_api/server
   conftest.py13094%25–>24
   test_statement_management.py330100% 
TOTAL12945793% 

@github-actions GitHub Actions
Copy link

Current Branch Main Branch
Coverage Badge Coverage Badge

@NoB0 NoB0 linked an issue Dec 15, 2023 that may be closed by this pull request
Add endpoint for population via form #58
Open
NoB0 added 24 commits December 19, 2023 10:45
@NoB0
Initial view with population form
f88b56b
@NoB0
Fix mypy issues
51a7038
@NoB0
Merge branch 'main' into feature/38-pkg-population-backend
dba14b2
@NoB0
Fix tests
bdd615a
@NoB0
Black
5ca9d81
@NoB0
Update CI pipeline
18d7990
@NoB0
Undo CI changes
3100850
@NoB0
Merge branch 'main' into feature/add-population-frontend
e3f158d
@NoB0
Update form based on new vocabulary
158709a
@NoB0
Formatting
13d3b9b
@NoB0
Merge branch 'main' into feature/38-pkg-population-backend
33d48cd
@NoB0
Add Flask configurations
5c248ca
@NoB0
Merge branch 'main' into feature/38-pkg-population-backend
c669028
@NoB0
Merge branch 'main' into feature/add-population-frontend
6139bf0
@NoB0
Update forms for PKG population
00c43f5
@NoB0
Remove useEffect
eb36aa2
@NoB0
Merge branch 'feature/add-population-frontend' into feature/38-pkg-po…
cf1db27 
…pulation-backend
@NoB0
Implement endpoint for statement management
121becd
@NoB0
Update Concept interface
512f4d4
@NoB0
Merge branch 'feature/add-population-frontend' into feature/38-pkg-po…
93304fa 
…pulation-backend
@NoB0
Remove preference form
cedc27f
@NoB0
Update parsing of request data
dad0ef3
@NoB0
Remove unrelated files
38a6ee4
@NoB0
Fixes #104
ed2ca6a
@NoB0 NoB0 marked this pull request as ready for review March 6, 2024 16:56
@NoB0 NoB0 requested a review from WerLaj as a code owner March 6, 2024 16:56
WerLaj
WerLaj approved these changes Mar 7, 2024
View reviewed changes
Copy link
Collaborator

@WerLaj WerLaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with some minor comments about docstrings

pkg_api/server/statements_management.py Outdated Show resolved Hide resolved
pkg_api/server/statements_management.py Outdated Show resolved Hide resolved
pkg_api/server/statements_management.py Show resolved Hide resolved
pkg_api/server/statements_management.py Show resolved Hide resolved
pkg_api/server/utils.py
element_data: Union[Dict[str, Any], str]
) -> TripleElement:
"""Parses a triple element received from HTTP request.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Raises block missing.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This method does not raise any exception.

pkg_api/server/utils.py Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WerLaj WerLaj WerLaj approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add endpoint for population via form
2 participants
@NoB0 @WerLaj