This repository has been archived by the owner on Jul 15, 2020. It is now read-only.
i18next support #85
Open
i18next support #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is amazing! Sorry for the delay I'm on holiday the moment but this looks really great! |
|
I know it's been a while, I've had to prioritise fixing a couple of critical issues first - they are now resolved and hope to take a look at this soon. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added i18next support #59
I took most of the implementation from with-i18next example. I added
_app.jsand exported it withtranslateHOC to injecti18nto all child components. Implementation also support XHR translation requests from the server. I implemented a customfetchrequest. With the use of locale library server gets the browser language and then language is being passed to pages. I also added a dropdown to show language changes. A more detailed explanation might be needed though.