Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes issue #2442 Time validation Fix for other languages #2443

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

ahamedalthaf
Copy link

Fixes below issue
#2442

@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Patch coverage: 48.38% and project coverage change: -0.72% ⚠️

Comparison is base (a9d7d03) 100.00% compared to head (41997bb) 99.28%.

Additional details and impacted files
@@             Coverage Diff             @@
##               dev    #2443      +/-   ##
===========================================
- Coverage   100.00%   99.28%   -0.72%     
===========================================
  Files          183      183              
  Lines         2201     2227      +26     
  Branches       594      607      +13     
===========================================
+ Hits          2201     2211      +10     
- Misses           0        8       +8     
- Partials         0        8       +8     
Files Changed Coverage Δ
src/locale/zh-tw.js 72.41% <0.00%> (-27.59%) ⬇️
src/locale/zh.js 72.41% <0.00%> (-27.59%) ⬇️
src/locale/zh-cn.js 100.00% <100.00%> (ø)
src/plugin/customParseFormat/index.js 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iamkun
Copy link
Owner

iamkun commented Sep 19, 2023

Thanks for the PR. It fixed the bug in the related issue.

However, is it possible not to add meridiemHour function to the locale file? Instead of using meridiem as moment.js does.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants