Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add usage trend link #2444

Merged
merged 30 commits into from
Oct 4, 2023
Merged

Add usage trend link #2444

merged 30 commits into from
Oct 4, 2023

Conversation

cwtuan
Copy link
Contributor

@cwtuan cwtuan commented Sep 10, 2023

As an active user of Day.js, I believe it would greatly benefit the community if we could include a link to the npm usage trend for Day.js and Moment.js.

This link will provide users with valuable insights into the usage trend, allowing them to make more informed decisions when choosing a modern date-time library. Providing this information will empower users to choose Day.js as a more modern alternative, considering its thriving community and ongoing development.

I kindly request you to consider this addition. Thanks

@iamkun
Copy link
Owner

iamkun commented Sep 19, 2023

Seems good, maybe an embedded chart or image will be better?

@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (2254635) 100.00% compared to head (233cb6e) 100.00%.
Report is 4 commits behind head on master.

❗ Current head 233cb6e differs from pull request most recent head c01b7c6. Consider uploading reports for the commit c01b7c6 to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##            master     #2444   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          183       183           
  Lines         2249      2201   -48     
  Branches       636       593   -43     
=========================================
- Hits          2249      2201   -48     

see 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cwtuan
Copy link
Contributor Author

cwtuan commented Sep 20, 2023

Unfortunately , Iframes cannot be embedded in Markdown on GitHub, as far as I know.

@iamkun
Copy link
Owner

iamkun commented Sep 20, 2023

how about a screenshot then?

PS: found another website that can make a comparison https://npmtrends.com/dayjs-vs-moment

@cwtuan
Copy link
Contributor Author

cwtuan commented Sep 21, 2023

Would you like me to embed this image in website? If so, I can try to figure out how to embed only the trend image, without extra information.

image

@iamkun
Copy link
Owner

iamkun commented Sep 21, 2023

Maybe Readme is a better place? It's the first impression of the project.

@cwtuan
Copy link
Contributor Author

cwtuan commented Sep 24, 2023

Thank you for your advice.

Based on your suggestion, I have made updates to the github merge request. I have added a screenshot to the README file and included a link to the npm-compare website for real-time data. This is important because the README serves as the first impression of the project.

@cwtuan cwtuan changed the base branch from dev to master September 24, 2023 11:46
@cwtuan
Copy link
Contributor Author

cwtuan commented Sep 29, 2023

any further suggestion about this MR?

@iamkun
Copy link
Owner

iamkun commented Oct 3, 2023

That looks great, thanks.

Before this PR gets merged, can you add a clickable link to the image the same as the link text above?

Or, maybe we can remove the text link and use an image combined with a a tag instead?

@cwtuan
Copy link
Contributor Author

cwtuan commented Oct 4, 2023

I appreciate your suggestion. The image now includes a clickable link, and the description has been removed.

@iamkun
Copy link
Owner

iamkun commented Oct 4, 2023

Cheers

@iamkun iamkun merged commit 55e89bf into iamkun:master Oct 4, 2023
Copy link

🎉 This PR is included in version 1.11.11 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants