-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add usage trend link #2444
Add usage trend link #2444
Conversation
Seems good, maybe an embedded chart or image will be better? |
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2444 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 183 183
Lines 2249 2201 -48
Branches 636 593 -43
=========================================
- Hits 2249 2201 -48 ☔ View full report in Codecov by Sentry. |
Unfortunately , Iframes cannot be embedded in Markdown on GitHub, as far as I know. |
how about a screenshot then? PS: found another website that can make a comparison https://npmtrends.com/dayjs-vs-moment |
Maybe Readme is a better place? It's the first impression of the project. |
Thank you for your advice. Based on your suggestion, I have made updates to the github merge request. I have added a screenshot to the README file and included a link to the npm-compare website for real-time data. This is important because the README serves as the first impression of the project. |
any further suggestion about this MR? |
That looks great, thanks. Before this PR gets merged, can you add a clickable link to the image the same as the link text above? Or, maybe we can remove the text link and use an image combined with a a tag instead? |
I appreciate your suggestion. The image now includes a clickable link, and the description has been removed. |
Cheers |
🎉 This PR is included in version 1.11.11 🎉 The release is available on: Your semantic-release bot 📦🚀 |
As an active user of Day.js, I believe it would greatly benefit the community if we could include a link to the npm usage trend for Day.js and Moment.js.
This link will provide users with valuable insights into the usage trend, allowing them to make more informed decisions when choosing a modern date-time library. Providing this information will empower users to choose Day.js as a more modern alternative, considering its thriving community and ongoing development.
I kindly request you to consider this addition. Thanks