Skip to content

Commit

Permalink
Improve formatting & linting to lean on Prettier instead of ESLint ru…
Browse files Browse the repository at this point in the history
…les (#46)

* Format al files

* Simplify lint config, leaning on Prettier for formatting
  • Loading branch information
iansan5653 committed Jul 25, 2023
1 parent 8a47c82 commit 1a03a50
Show file tree
Hide file tree
Showing 5 changed files with 724 additions and 112 deletions.
58 changes: 5 additions & 53 deletions .eslintrc.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,9 @@
},
"extends": [
"eslint:recommended",
"google",
"plugin:@typescript-eslint/recommended",
"plugin:mocha/recommended"
"plugin:mocha/recommended",
"plugin:prettier/recommended"
],
"globals": {
"Atomics": "readonly",
Expand All @@ -20,57 +20,9 @@
"sourceType": "module"
},
"parser": "@typescript-eslint/parser",
"plugins": ["jsdoc", "mocha"],
"plugins": ["jsdoc", "mocha", "prettier"],
"rules": {
"mocha/no-skipped-tests": "off",
"mocha/no-setup-in-decribe": "off",
//: Off because there are many times when you want hooks for a single case
"mocha/no-hooks-for-single-case": "off",
//: Off because Prettier controls this
"indent": "off",
"@typescript-eslint/indent": "off",
"linebreak-style": "off",
"@typescript-eslint/linebreak-style": "off",
//: Off because conflicts with jsdoc plugin
"valid-jsdoc": "off",
"require-jsdoc": "off",
"jsdoc/check-alignment": 1,
//: Off because https://github.com/gajus/eslint-plugin-jsdoc/issues/334
"jsdoc/check-indentation": 0,
"jsdoc/check-param-names": 1,
"jsdoc/check-syntax": 1,
"jsdoc/check-tag-names": 1,
"jsdoc/implements-on-classes": 1,
"jsdoc/match-description": 1,
"jsdoc/no-types": 1,
"jsdoc/require-jsdoc": "off",
"jsdoc/require-param": 1,
"jsdoc/require-param-description": 1,
"jsdoc/require-param-name": 1,
"comma-dangle": ["error", "never"],
"quotes": "off",
"no-console": "off",
"no-dupe-class-members": "off",
"no-param-reassign": "error",
"@typescript-eslint/prefer-for-of": "error",
"@typescript-eslint/no-parameter-properties": "off",
"@typescript-eslint/camelcase": "off",
"@typescript-eslint/array-type": ["error", {"default": "array-simple"}],
//: Off because sometimes using any makes sense; ie: `(...args: any[]) -> any`
"@typescript-eslint/no-explicit-any": "off",
"max-len": [
"error",
{
"code": 80,
"tabWidth": 2,
"ignoreComments": false,
"ignoreTrailingComments": false,
"ignoreUrls": true,
"ignoreStrings": false,
"ignoreTemplateLiterals": false,
"ignoreRegExpLiterals": true
}
],
"operator-linebreak": ["off"]
"mocha/no-setup-in-describe": "off",
"mocha/no-skipped-tests": "off"
}
}
Loading

0 comments on commit 1a03a50

Please sign in to comment.