Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ReactEditor.focus triggering onValueChange unexpectedly #5679

Conversation

WindrunnerMax
Copy link
Contributor

@WindrunnerMax WindrunnerMax commented Jul 10, 2024

Related to #5672

Fix the issue where ReactEditor.focus triggers onValueChange unexpectedly.

  • Update ReactEditor.focus in packages/slate-react/src/plugin/react-editor.ts to set the editor's selection without triggering onValueChange.
  • Modify onContextChange function in packages/slate-react/src/components/slate.tsx to call onValueChange only for operations that modify the editor's children.
  • Add a test in packages/slate-react/test/react-editor.spec.tsx to ensure ReactEditor.focus does not trigger onValueChange.

For more details, open the Copilot Workspace session.

Copy link

changeset-bot bot commented Jul 10, 2024

⚠️ No Changeset found

Latest commit: 21aa5e3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@WindrunnerMax WindrunnerMax deleted the fix-focus-onvaluechange branch July 10, 2024 03:19
@WindrunnerMax
Copy link
Contributor Author

Sorry, I'm currently trying out GitHub Copilot Workspace. My mistake caused an incorrect Pull Request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant