Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(website): document custom transformer step implementation #155

Merged
merged 3 commits into from
Sep 25, 2024

Conversation

ahaan1984
Copy link
Contributor

@ahaan1984 ahaan1984 commented Sep 10, 2024

Re-implementation of #116, closes issue #47

Edit: Changes made mostly to incorporate the feedback from #47:

  • fixed the broken link to steps.
  • Used sentence case and fixed minor spelling errors.
  • Added a brief guideline regarding setting up a virtual environment (can elaborate more on this if required).
  • Removed conclusion and added a brief contribution guide at the end.

@deepyaman
Copy link
Collaborator

deepyaman commented Sep 12, 2024

Re-implementation of #116, closes issue #47

@ahaan1984 Thanks! I have gone ahead and approved the CI workflow (sorry I missed doing this earlier).

I'll review this soon. To help me out, can you update the description to include the high-level changes you made from #116?

Edit: Nice, looks like the docs build is passing!

@codecov-commenter
Copy link

codecov-commenter commented Sep 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.70%. Comparing base (cdeeb58) to head (b3331ae).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #155   +/-   ##
=======================================
  Coverage   88.70%   88.70%           
=======================================
  Files          27       27           
  Lines        2009     2009           
=======================================
  Hits         1782     1782           
  Misses        227      227           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@deepyaman deepyaman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a quick comment—can you make sure to use "IbisML" (instead of "ibisML") everyhere?

docs/tutorial/how_to_create_your_own_transformer.qmd Outdated Show resolved Hide resolved
@ahaan1984
Copy link
Contributor Author

Just a quick comment—can you make sure to use "IbisML" (instead of "ibisML") everyhere?

Sure, will do so!

@ahaan1984
Copy link
Contributor Author

ahaan1984 commented Sep 12, 2024

Have made the suggested changes, please do check.

@ahaan1984
Copy link
Contributor Author

Hi.
Are there any changes to be made from my end?

@deepyaman
Copy link
Collaborator

Hi. Are there any changes to be made from my end?

Sorry for the delay in getting back to you! I think this is great overall; I will go ahead and merge.

I was working on some general improvements to the content, but it looks like that work was lost when my machine was wiped without any notification; I'll see if I can revisit that at some point in the future.

Regardless, congrats on your first IbisML contribution @ahaan1984!

Copy link
Collaborator

@deepyaman deepyaman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@deepyaman deepyaman merged commit 1b0728d into ibis-project:main Sep 25, 2024
4 checks passed
@ahaan1984
Copy link
Contributor Author

Thank you! I look forward to contributing more actively to IbisML in the future!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants