-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(website): document custom transformer step implementation #155
Conversation
@ahaan1984 Thanks! I have gone ahead and approved the CI workflow (sorry I missed doing this earlier). I'll review this soon. To help me out, can you update the description to include the high-level changes you made from #116? Edit: Nice, looks like the docs build is passing! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #155 +/- ##
=======================================
Coverage 88.70% 88.70%
=======================================
Files 27 27
Lines 2009 2009
=======================================
Hits 1782 1782
Misses 227 227 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a quick comment—can you make sure to use "IbisML" (instead of "ibisML") everyhere?
Sure, will do so! |
Have made the suggested changes, please do check. |
Co-authored-by: Deepyaman Datta <deepyaman.datta@utexas.edu>
Hi. |
Sorry for the delay in getting back to you! I think this is great overall; I will go ahead and merge. I was working on some general improvements to the content, but it looks like that work was lost when my machine was wiped without any notification; I'll see if I can revisit that at some point in the future. Regardless, congrats on your first IbisML contribution @ahaan1984! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! I look forward to contributing more actively to IbisML in the future! |
Re-implementation of #116, closes issue #47
Edit: Changes made mostly to incorporate the feedback from #47: