docs: fix warnings from deprecations #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #166 +/- ##
==========================================
+ Coverage 85.53% 88.70% +3.16%
==========================================
Files 27 27
Lines 1964 2009 +45
==========================================
+ Hits 1680 1782 +102
+ Misses 284 227 -57 ☔ View full report in Codecov by Sentry. |
jcrist
approved these changes
Sep 16, 2024
deepyaman
reviewed
Sep 16, 2024
| @@ -130,10 +130,9 @@ flight_data_with_unique_key | |||
| ``` | |||
|
|
|||
| ```{python} | |||
| # FIXME(deepyaman): Proposed key isn't unique for actual departure date. | |||
There was a problem hiding this comment.
@lostmygithubaccount I would argue this still needs to be fixed. (And, if dropped, dropped consistently, including in pytorch.qmd and the example notebook.)
There was a problem hiding this comment.
should have noted in the PR, that's fine, I'd just prefer an issue opened versus a code comment in the doc page
deepyaman
added a commit
to deepyaman/ibisml
that referenced
this pull request
Sep 16, 2024
Co-authored-by: Deepyaman Datta <deepyaman.datta@utexas.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dropna->drop_nulluse
.filter()instead of the brackets thing