Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(examples): use built-in train-test split code #172

Merged
merged 4 commits into from
Sep 17, 2024

Conversation

jitingxu1
Copy link
Collaborator

@jitingxu1 jitingxu1 commented Sep 17, 2024

replace customized train test split code to the train_test_split function

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.70%. Comparing base (6dce35e) to head (37b66bf).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #172   +/-   ##
=======================================
  Coverage   88.70%   88.70%           
=======================================
  Files          27       27           
  Lines        2009     2009           
=======================================
  Hits         1782     1782           
  Misses        227      227           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@deepyaman deepyaman changed the title docs: Update train test split docs(examples): use built-in train-test split code Sep 17, 2024
Copy link
Collaborator

@deepyaman deepyaman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interestingly, your reproducible train-test split changed. 😂 Not looking into it; I assume it's because the logic is written differently in the function.

@deepyaman deepyaman merged commit cdeeb58 into ibis-project:main Sep 17, 2024
4 checks passed
@jitingxu1
Copy link
Collaborator Author

changed

Same logic but with different random_seed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants