Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable nodejs:10. #166

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

falkzoll
Copy link

@falkzoll falkzoll commented Oct 6, 2023

Disable/remove usage of nodejs:10.

Description

Disable/remove usage of nodejs:10. Use nodejs:20 instead.

Related issue and scope

  • I opened an issue to propose and discuss this change (#????)

My changes affect the following components

  • API
  • Controller
  • Message Bus (e.g., Kafka)
  • Loadbalancer
  • Invoker
  • Intrinsic actions (e.g., sequences, conductors)
  • Data stores (e.g., CouchDB)
  • Tests
  • Deployment
  • CLI
  • General tooling
  • Documentation

Types of changes

  • Bug fix (generally a non-breaking change which closes an issue).
  • Enhancement or new feature (adds new functionality).
  • Breaking change (a bug fix or enhancement which changes existing behavior).

Checklist:

  • I signed an Apache CLA.
  • I reviewed the style guides and followed the recommendations (Travis CI will check :).
  • I added tests to cover my changes.
  • My changes require further changes to the documentation.
  • I updated the documentation where necessary.

- Also adjust tests to the new open files limit (1000->998 files) introduced with the new github action runner version.
@falkzoll falkzoll force-pushed the updateTests branch 9 times, most recently from 9891c1a to a2eec3a Compare October 9, 2023 17:20
@codecov-commenter
Copy link

codecov-commenter commented Oct 10, 2023

Codecov Report

Merging #166 (4840e90) into master (fc0d7ea) will decrease coverage by 0.28%.
The diff coverage is n/a.

❗ Current head 4840e90 differs from pull request most recent head b843ea9. Consider uploading reports for the commit b843ea9 to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##           master     #166      +/-   ##
==========================================
- Coverage   52.29%   52.02%   -0.28%     
==========================================
  Files         195      195              
  Lines        9872     9872              
  Branches      604      604              
==========================================
- Hits         5163     5136      -27     
- Misses       4709     4736      +27     

see 2 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants