Skip to content

Commit

Permalink
librtas: deprecate rtas_delay_timeout()
Browse files Browse the repository at this point in the history
Despite its description rtas_delay_timeout() sets an internal timeout
value as opposed to returning the delay time as documented. This timeout
short cuts the logic in handle_delay(). Fortunately this is unsed by
default. The library should run operations to completion, otherwise we
risk leaving things in an unrecoverable state.

Mark rtas_delay_timeout() with __attribute__ ((deprecated)) as
preperation for eventual removal.

Signed-off-by: Tyrel Datwyler <tyreld@linux.ibm.com>
  • Loading branch information
tyreld committed Feb 7, 2024
1 parent b8d3405 commit e7eff65
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions librtas_src/syscall_calls.c
Original file line number Diff line number Diff line change
Expand Up @@ -333,6 +333,7 @@ int rtas_cfg_connector(char *workarea)
* @param timeout_ms timeout in milli-seconds
* @return delay time
*/
__attribute__ ((deprecated))
int rtas_delay_timeout(uint64_t timeout_ms)
{
int rc;
Expand Down

0 comments on commit e7eff65

Please sign in to comment.