Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User Agent Analysis Integration #21

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

tmack-etg
Copy link

Description

Motivation and Context

Fixes #

How Has This Been Tested?

Checklist:

  • [] I have added a Signed-off-by
  • [] Either no new documentation is required by this change, OR I added new documentation
  • [] Either no new tests are required by this change, OR I added new tests
  • [] I have run pep8 and pylint. I have cleaned up all valid errors and warnings in code I have added or modified. These tools may generate false positives. Don't be worried about ignoring some errors or warnings. The goal is clean, consistent, and readable code.

Signed-off-by:

* [DONE] ADD LICENSE
* [DONE] UPDATE LOOKUP ERROR TO VALUE ERROR
* [DONE] remove hello world
* [DONE] Fix config file generation
Copy link
Collaborator

@mscherfling mscherfling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see outstanding comments


pip install <filename>.tar.gz


Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

resilient-circuits config and then further editing to add url and api_key information

@@ -0,0 +1 @@
<<PUT YOUR LICENSE TEXT HERE>>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mit

"automatic_tasks": [],
"scripts": [],
"workflows": [u"user_agent_workflow"],
"actions": []
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should be an example run ("actions") as part of this distribution. You can add by doing:

resilient-circuits codegen --reload fn_useragentanalysis --rule "new rule"

setup(
name='fn_useragentanalysis',
version='1.0.0',
license='<<insert here>>',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs to be filled out -- see trello card for settings

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants