Ansible tower #73
Open
Ansible tower #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Get latest ibmresilient:master
mscherfling
reviewed
Jun 7, 2021
fn_ansible_tower/entrypoint.sh
Outdated
| @@ -7,12 +7,10 @@ APP_CONFIG_SHA=`sha256sum /etc/rescircuits/app.config` | |||
| resilient-circuits run & CIRCUITS_PID=`echo $!` | |||
| while true | |||
| do | |||
| echo -n "`date +'%F %T,%N INFO '`" | |||
| # | ||
| ## notes permissions | ||
| #edit_all_incident_notes | ||
| edit_all_incident_notes |
There was a problem hiding this comment.
This updates incident notes, does this permission not required for updating notes?
| #delete_all_incidents | ||
| #edit_all_incidents_members | ||
| #edit_all_incidents_owner | ||
| #edit_all_incidents_status | ||
| # | ||
| ## incident fields, artifacts, attachments, milestones, datatables | ||
| #edit_all_incidents_fields | ||
| edit_all_incidents_fields |
| @@ -10,17 +10,17 @@ read_function | |||
| # | |||
| ## incident permissions | |||
| #create_incident | |||
| #read_all_incidents | |||
| read_all_incidents | |||
There was a problem hiding this comment.
package uses data table to update the results. so felt its needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modifications:
Function Name: Ansible Tower List Job Templates
Issue: Some elements of the results from restful call response doesn't has a project name information, but as per the current code if project name info is mandatory.
Modification: Changed the code to handle the situation when project information is not available, filling those project name column with null values.
Error Code Line:
return [project for project in results if compiled.match(project['summary_fields']['project']['name'])]
Fixed Line code:
pro_list = []
for project in results:
pro_name = project.get("summary_fields", {}).get("project", {}).get("name", None)
if pro_name:
if compiled.match(pro_name):
pro_list.append(project)
return pro_list
Ansible Tower Run Job - Incident
Post process script modified. to handle if any result key is not available
Ansible Tower Run Job - Datatable
Post process script modified. to handle if any result key is not available
Ansible Tower Run Job - Artifact
Post process script modified. to handle if any result key is not available
Ansible Tower Get job results
Post process script modified. Currently for notes & attachments save as type its only executing notes section. modified to execute defined sections bases on save as type.