Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding config option to set the timeout for the Elastic request #91

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

smoreau
Copy link

@smoreau smoreau commented Sep 23, 2023

Description

The purpose of this change is to add a new configuration option to set the timeout when performing an Elastic request.
I needed it on my Elastic cluster when performing search on large amount of data.

Motivation and Context

As explained in the description, the motivation of this change is to allow us to set the timeout for the Elastic request. The default timeout is quite low.

How Has This Been Tested?

It has been successfully tested on our test Resilient environment.
We also did non-regression testing : if you do not add this option in the configuration file, it is still working as before.

Checklist:

  • I have added a Signed-off-by
  • Either no new documentation is required by this change, OR I added new documentation
  • Either no new tests are required by this change, OR I added new tests
  • I have run pep8 and pylint. I have cleaned up all valid errors and warnings in code I have added or modified. These tools may generate false positives. Don't be worried about ignoring some errors or warnings. The goal is clean, consistent, and readable code.

Signed-off-by: Stéphane Moreau smoreau@logikdev.com

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant