Add OpenJ9PropsExt properties for serviceability_jvmti_j9 #505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vm.cds is set to false for serviceability/jvmti/CanGenerateAllClassHook/CanGenerateAllClassHook.java which is specific to hotspot sharedclass; vm.flagless is set to true for serviceability/jvmti/RedefineClasses/RedefineLeak.java which OpenJ9 passes; vm.opt.final.ClassUnloading is set to false for serviceability/jvmti/RedefineClasses/RedefinePreviousVersions.java which looks for a hotspot specific "Class unloading: has_previous_versions = false". Signed-off-by: Jason Feng <fengj@ca.ibm.com>
|
I don't think the cherry pick link in the description is what you intended. |
|
I assume cherry pick of ibmruntimes/openj9-openjdk-jdk19#34 |
|
Yeah, updated the link. |
babsingh
approved these changes
Oct 10, 2022
There was a problem hiding this comment.
LGTM. Changes tested and verified in ibmruntimes/openj9-openjdk-jdk19#34.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
vm.cdsis set tofalseforserviceability/jvmti/CanGenerateAllClassHook/CanGenerateAllClassHook.javawhich is specific to hotspot sharedclass;vm.flaglessis set totrueforserviceability/jvmti/RedefineClasses/RedefineLeak.javawhich OpenJ9 passes;vm.opt.final.ClassUnloadingis set tofalseforserviceability/jvmti/RedefineClasses/RedefinePreviousVersions.javawhich looks for a hotspot specificClass unloading: has_previous_versions = false.Cherry-pick ibmruntimes/openj9-openjdk-jdk19#34
closes eclipse-openj9/openj9#16074
Signed-off-by: Jason Feng fengj@ca.ibm.com