Skip to content

Commit

Permalink
Ensure test-image-openj9 target fails when java -version fails
Browse files Browse the repository at this point in the history
Previously, the exit status could come from tee, which succeeds.

There is logic in make/autoconf/basics.m4 that checks for support and
then opportunistically adds -o pipefail to SHELL in the makefiles, which
already accomplishes the same thing, but only when pipefail support is
detected. That should be most of the time, but it's not obvious that we
should expect pipefail support in all cases.

With this change, the target will fail whenever java -version fails,
regardless of the pipefail setting.
  • Loading branch information
jdmpapin committed Jan 18, 2023
1 parent dcef2ef commit 192d8ee
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions closed/custom/Main.gmk
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# ===========================================================================
# (c) Copyright IBM Corp. 2017, 2021 All Rights Reserved
# (c) Copyright IBM Corp. 2017, 2023 All Rights Reserved
# ===========================================================================
# This code is free software; you can redistribute it and/or modify it
# under the terms of the GNU General Public License version 2 only, as
Expand Down Expand Up @@ -76,7 +76,7 @@ ALL_TARGETS += debug-image
test-image-openj9 : exploded-image
@+$(OPENJ9_MAKE) openj9_test_image
ifneq ($(COMPILE_TYPE), cross)
$(JDK_OUTPUTDIR)/bin/java -version 2>&1 | $(TEE) $(TEST_IMAGE_DIR)/openj9/java-version.txt
rc=0; $(JDK_OUTPUTDIR)/bin/java -version >$(TEST_IMAGE_DIR)/openj9/java-version.txt 2>&1 || rc=$$?; $(CAT) $(TEST_IMAGE_DIR)/openj9/java-version.txt; exit "$$rc"
endif

ALL_TARGETS += test-image-openj9
Expand Down

0 comments on commit 192d8ee

Please sign in to comment.