Restore creation of dtfj, dtfjview & traceformat jars #65
Conversation
keithc-ca
commented
Mar 15, 2018
keithc-ca
commented
- Enables basic commands in jdmpview.
- Content in those jars forms part of the API to an SDK. Used, for example, by HealthCenter.
- Include only necessary OpenJ9 classes in tools.jar.
- Revert many changes to jdk/make/CreateJars.gmk by moving as much as possible to closed/make/CreateJars.gmk.
- Use default APP_CLASSPATH for jdmpview, jextract and traceformat.
- Add missing IBM copyright notice.
* revert many changes to jdk/make/CreateJars.gmk * use default APP_CLASSPATH for jdmpview, jextract and traceformat * add missing IBM copyright notice Signed-off-by: Keith W. Campbell <keithc@ca.ibm.com>
|
I'm not convinced this is the correct way to go. Although having the jars in the ext directory is how it works for IBM Java 8, its not the correct way to do things. Putting these jars in the ext directory incurs some costs. Both in the disk size of a JRE (which shouldn't contain these development tools), and also in class loading performance at runtime. Any class lookup based on the system classloader will be a little slower because of these additional jar files are in the ext directory. |
|
@pshipton Do you have an alternative proposal for how to handle this? If you do, can you create an issue to track the discussion? |
|
@DanHeidinga I think it was correct the way it was originally before this PR was merged. I suppose we shouldn't just revert this PR since moving changes to closed/make is desired. I've opened #67 and eclipse-openj9/openj9#1539. |
