Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/pass authorization headers #21

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

ctrlaltdylan
Copy link

This is a pretty major change and if you're against it I totally understand.

  1. This passes the Dialogflow Client Access Token to the GuzzleHttpClient's constructor as a headers entry so it's available on all requests
  2. This adds Codeception as a testing suite with a rudimentary test for testing the integration for a basic query
  3. This bypasses the internal Dialogflow\HttpClient\GuzzleHttpClient and just instantiates one in the DialogFlow\Client instead. In a perfect world, instantiation would be in a Factory or through a simple container, but I don't like to complicate if it's not necessary.
  4. Updates the README to include the missing sessionId that needs passed as an argument to the query

Let me know your thoughts, if it's too drastic of a change that's alright I'll just maintain my fork.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant