-
-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WAD: add support for tags and labels #57
Draft
madebr
wants to merge
1
commit into
icculus:main
Choose a base branch
from
madebr:wad
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've modified the commit to only allow certain elements in a folder: those that are part of a map. This is the output for doom2.wad: Output of `./test_physfs "mount /tmp/DOOM2.WAD /doom2 0" "tree /doom2" "quit" `
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the WAD loader flattens all files in one folder, but the unofficial DOOM specs says a zero-size directory entry means a label/marker.
This pr modifes the WAD loader to put all directory entries that follow this label/marker in a new directory.
When built on top of #56 (because this uses the `tree` command), this results in the following tree
It looks
E1M9
collects a lot of extra directory entries.Perhaps the loader should only allow the 10 specific elements(BLOCKMAP - VERTEXES) when it sees a
ExMy
orMAPxx
label. But I don't know how much doom specific we want this WAD loader to be.Anyways, the current WAD loader will overwrite names with equal filename.