Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin iminuit #272

Merged
merged 11 commits into from
Sep 21, 2024
Merged

Pin iminuit #272

merged 11 commits into from
Sep 21, 2024

Conversation

tianluyuan
Copy link
Contributor

@tianluyuan tianluyuan commented Sep 20, 2024

Pin iminuit<2.27.0. 2.27.0 introduced a change in the minimization algorithm (scikit-hep/iminuit#1009) that does not ensure reproducibility and led to the tests failing.

@tianluyuan tianluyuan marked this pull request as ready for review September 21, 2024 02:34
@tianluyuan tianluyuan changed the title minor Pin iminuit Sep 21, 2024
@tianluyuan
Copy link
Contributor Author

See also scikit-hep/iminuit#1041

@tianluyuan tianluyuan merged commit 3c9060b into main Sep 21, 2024
43 checks passed
@tianluyuan tianluyuan deleted the testing branch September 21, 2024 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants