cycle combo_box with keybinds

[casperstorm]

A few keybinds optimizations for combo_box:

1. When pressing ↑ at the very first entry you cycle to bottom
2. When pressing ↓ at the very last entry you cycle to top
3. Add support for Tab and Shift+Tab which does the same as ↓ and ↑.

[hecrj]

Awesome! Thanks 🎉

[mtkennerly]

Add support for Tab and Shift+Tab which does the same as ↓ and ↑.

Would this interfere with using tab to cycle through elements in a form, when that form includes a combobox?

[hecrj]

Add support for Tab and Shift+Tab which does the same as ↓ and ↑.

Would this interfere with using tab to cycle through elements in a form, when that form includes a combobox?

As long as the form handler honors the event::Status, it should be fine. These interactions are capturing the events.

[mtkennerly]

As long as the form handler honors the event::Status, it should be fine. These interactions are capturing the events.

The fact that they're captured is why I was concerned 😅 If you honor the status, but you generally use tab for focus_next, then how would you cycle focus out of a combobox?

One solution might be:

• click in combobox -> triggers overlay -> tab cycles through options in overlay
• escape closes overlay -> tab cycles focus past combobox

However, at the moment, escape also clears the cursor in the combobox and removes focus, so focus_next would lose its place.