Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update arc.rs with improved documentation #2008

Merged
merged 2 commits into from
Aug 15, 2023
Merged

Update arc.rs with improved documentation #2008

merged 2 commits into from
Aug 15, 2023

Conversation

ua-kxie
Copy link
Contributor

@ua-kxie ua-kxie commented Aug 7, 2023

added units and improved description to field comments of Arc and Ellipse structs.

@hecrj hecrj added improvement An internal improvement documentation labels Aug 15, 2023
@hecrj hecrj added this to the 0.10.0 milestone Aug 15, 2023
ua-kxie and others added 2 commits August 15, 2023 07:52
@ua-kxie @hecrj
Update arc.rs with improved documentation
76ffbbd 
added units and improved description to field comments of Arc and Ellipse structs.
@hecrj
Update CHANGELOG
5dbf5ad
@hecrj hecrj force-pushed the arc-and-ellipse-documentation branch from 3646f21 to 5dbf5ad Compare August 15, 2023 05:53
hecrj
hecrj approved these changes Aug 15, 2023
View reviewed changes
Copy link
Member

@hecrj hecrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Maybe we should think about creating an opaque Radians type eventually, analogous to our Pixels type.

@hecrj hecrj enabled auto-merge August 15, 2023 05:54
@hecrj hecrj merged commit aadf682 into iced-rs:master Aug 15, 2023
9 of 10 checks passed
@hecrj
Copy link
Member

hecrj commented Aug 15, 2023

We actually have a Radians type already!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hecrj hecrj hecrj approved these changes

Assignees
No one assigned
Labels
documentation improvement An internal improvement
Projects
None yet
Milestone
0.10.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ua-kxie @hecrj