Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Don't use &mut self for view() #2034

Merged
merged 1 commit into from
Aug 16, 2023
Merged

[docs] Don't use &mut self for view() #2034

merged 1 commit into from
Aug 16, 2023
+1 −1

Conversation

PolyMeilex
Copy link
Contributor

Using &mut self for view method could be misleading for people not familiar with ELM

hecrj
hecrj approved these changes Aug 16, 2023
View reviewed changes
Copy link
Member

@hecrj hecrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@hecrj hecrj merged commit 2a3cb0f into iced-rs:master Aug 16, 2023
9 of 10 checks passed
@hecrj hecrj added improvement An internal improvement documentation labels Aug 16, 2023
@hecrj hecrj added this to the 0.10.0 milestone Aug 16, 2023
@PolyMeilex PolyMeilex deleted the PolyMeilex-patch-1 branch August 16, 2023 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hecrj hecrj hecrj approved these changes

Assignees
No one assigned
Labels
documentation improvement An internal improvement
Projects
None yet
Milestone
0.10.0
Development

Successfully merging this pull request may close these issues.
2 participants
@PolyMeilex @hecrj