Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

split: Remove unneeded Message: Clone bound #141

Merged
merged 1 commit into from
Jul 9, 2023

Conversation

f4814
Copy link
Contributor

@f4814 f4814 commented Jul 7, 2023

As far as I can see this bound is not needed anywhere and removing it should not break anything

Copy link
Collaborator

@genusistimelord genusistimelord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the clippy warnings and formatting of the source.

@f4814 f4814 changed the title spinner: Remove unneeded Message: Clone bound split: Remove unneeded Message: Clone bound Jul 8, 2023
@f4814
Copy link
Contributor Author

f4814 commented Jul 8, 2023

As far as I can see none of the warnings are caused by my commit or am I missing something? AFAICT every warning/error originates from src/native/cupertino or examples/cupertino which do not use the split.
(Also: Yes I was stupid yesterday and wrote spinner instead of split)

@genusistimelord genusistimelord merged commit 2bfe02a into iced-rs:main Jul 9, 2023
1 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants