Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add multiple modals example #174

Merged
merged 1 commit into from
Sep 5, 2023

Conversation

lucatrv
Copy link
Contributor

@lucatrv lucatrv commented Aug 31, 2023

No description provided.

@lucatrv
Copy link
Contributor Author

lucatrv commented Aug 31, 2023

@genusistimelord before merging this please see issue #175

@genusistimelord
Copy link
Collaborator

genusistimelord commented Sep 1, 2023

could you also remove the not needed comment from the documentation.. https://github.com/iced-rs/iced_aw/blob/main/src/native/modal.rs#L68

Maybe Expand this with a small explanation of how the Modal is shown or hidden since the last changes you made to it?

@lucatrv
Copy link
Contributor Author

lucatrv commented Sep 3, 2023

@genusistimelord please review the new PR, and let me know if everything is ok or if it should be further improved. Then I will also update the documentation comment, so please do not merge it yet.

@genusistimelord
Copy link
Collaborator

@genusistimelord please review the new PR, and let me know if everything is ok or if it should be further improved. Then I will also update the documentation comment, so please do not merge it yet.

looks good.

@lucatrv
Copy link
Contributor Author

lucatrv commented Sep 4, 2023

@genusistimelord, while updating the documentation comment that you pointed me out I noticed that most of the links of the iced_aw documentation have duplicated identical labels. For instance [Modal](Modal) which from what I know can be simplified as [Modal]. Please let me know if I should:

  1. Do not care about that and update only the comment that you pointed me out
  2. Update all comments in modal.rs removing the unneeded duplicated identical labels
  3. Remove the unneeded duplicated identical labels from all iced_aw documentation

@genusistimelord
Copy link
Collaborator

you can fix those too but id prefer it to be in a separate PR if you want to go though and tidy up all the documentation.

@lucatrv
Copy link
Contributor Author

lucatrv commented Sep 4, 2023

Should I fix that single comment in this PR, and then tidy up all documentation links in another PR?

@genusistimelord
Copy link
Collaborator

probably if there is that much that needs to be fixed best to do it in the other PR with the rest.

@lucatrv
Copy link
Contributor Author

lucatrv commented Sep 5, 2023

So you can go ahead merging this, and I will open a separate PR for the documentation.

Copy link
Collaborator

@genusistimelord genusistimelord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

everything looks good thank you.

@genusistimelord genusistimelord merged commit 8abe652 into iced-rs:main Sep 5, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants