Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap example is broken #189

Merged
merged 4 commits into from
Oct 12, 2023
Merged

Wrap example is broken #189

merged 4 commits into from
Oct 12, 2023

Conversation

ojji
Copy link
Contributor

@ojji ojji commented Oct 8, 2023

The wrap example looks like this to me:
broke

Changing the controls column width from the default iced::Length::Shrink to either iced::Length::Fixed(value) or iced::Length::FillPortion(value) fixes the example program.

@genusistimelord
Copy link
Collaborator

genusistimelord commented Oct 8, 2023

yeah that is weird as iced::Shrink should make it the smallest possible size. So something is definitely not right in column or within the Text portion which is causing the size of the boxes to get Extra big.

would need to look into why its not working as just changing the type to fixed or fill portion is not a correct fix its just a band aid

@ojji
Copy link
Contributor Author

ojji commented Oct 9, 2023

I agree this is just a band aid. It looks like to me that the NumberInput is causing the issue, at least changing the default width in the NumberInput::new() function from Fill to Shrink will stop pushing the controls column all the way to the right.
However i'm not familiar with the library enough to know if that would break other things or not, or is the right solution anyway.

genusistimelord
genusistimelord previously approved these changes Oct 9, 2023
Copy link
Collaborator

@genusistimelord genusistimelord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@genusistimelord genusistimelord merged commit 44c44cf into iced-rs:main Oct 12, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants