icon fonts #197
Merged
icon fonts #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
not really decoupling it if your still using it internally. what does the nerd font give btw? |
I would say this describes it best But out of this I'd really like the seti icons (default vscode icons) and the material icons. I misspoke about decoupling, it is more straight forward what is happening now if you want to use the bootstrap icons vs another icon font. |
|
what is the license for it? |
|
|
since licenses are a issue, I believe using nerd font will be a bad idea. I will add the smaller fonts that make it up. |
|
their license is ok. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
icon_to_string()function to make code cleaner